[Improvement-18249][DAO] Route ScheduleMapper access through ScheduleDao#18251
Merged
Conversation
SbloodyS
previously approved these changes
May 13, 2026
Tracking issue: apache#18249 Expose the methods the api layer needs on ScheduleDao (queryByWorkflowDefinitionCode, querySchedulerListByProjectName, queryByProjectAndWorkflowDefinitionCodePaging, querySchedulesByWorkflowDefinitionCodes, queryScheduleListByTenant, queryScheduleByWorkerGroup) and replace every direct ScheduleMapper reference in dolphinscheduler-api with the Dao, so Mapper usage stays inside dolphinscheduler-dao.repository as documented in dolphinscheduler-dao/CLAUDE.md. Notes: - BaseDao#deleteById and BaseDao#updateById return boolean (Mapper returned int). Affected call sites in SchedulerServiceImpl and WorkflowDefinitionServiceImpl were adapted (boolean delete = scheduleDao.deleteById(id); if (!delete)). Test mocks switched from thenReturn(1/0) to thenReturn(true/false). - selectById was replaced with the IDao#queryById equivalent. - WorkerGroupServiceImpl previously inlined a BaseMapper.selectList(QueryWrapper) to find schedules referencing a worker group; the QueryWrapper is now encapsulated as ScheduleDao#queryScheduleByWorkerGroup so the api layer no longer constructs a raw QueryWrapper for this lookup. No production behavior changes; the Mapper interface itself is untouched.
|
SbloodyS
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES, ops 4.7
Purpose of the pull request
Tracking issue: #18249
Expose the methods the api layer needs on ScheduleDao (queryByWorkflowDefinitionCode, querySchedulerListByProjectName, queryByProjectAndWorkflowDefinitionCodePaging, querySchedulesByWorkflowDefinitionCodes, queryScheduleListByTenant, queryScheduleByWorkerGroup) and replace every direct ScheduleMapper reference in dolphinscheduler-api with the Dao, so Mapper usage stays inside dolphinscheduler-dao.repository as documented in dolphinscheduler-dao/CLAUDE.md.
Notes:
No production behavior changes; the Mapper interface itself is untouched.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md