[Improvement-18249][DAO] Route AlertGroupMapper and AccessTokenMapperaccess through repository Dao#18261
Open
ruanwenjun wants to merge 1 commit into
Open
Conversation
ruanwenjun
force-pushed
the
dao/alert-group-and-access-token
branch
6 times, most recently
from
0ec0921 to
0ac5d7b
Compare
… access through repository Dao Introduce AlertGroupDao and AccessTokenDao so the api layer depends only on the repository abstraction. The two mappers are bundled because UsersServiceImpl and ResourcePermissionCheckServiceImpl share both. AlertGroupDao preserves the mapper's custom ORDER BY update_time DESC in queryAllGroupList (cannot be replaced with IDao.queryAll). existGroupName returns primitive boolean via Boolean.TRUE.equals so callers drop the == Boolean.TRUE dance. AccessTokenDao renames mapper.selectAccessTokenPage to queryAccessTokenPage and mapper.deleteAccessTokenByUserId to deleteByUserId. updateById in AccessTokenServiceImpl switches from int to boolean so the guard becomes !success instead of i <= 0. AlertGroupControllerTest.clear() replaces the BaseMapper.delete(QueryWrapper) idiom with a queryAllGroupList stream + deleteById loop so the controller test can stop reaching into MyBatis-Plus internals. Tracking issue: apache#18249
ruanwenjun
force-pushed
the
dao/alert-group-and-access-token
branch
from
0ac5d7b to
fb27155
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES, gpt 5.5
Purpose of the pull request
Introduce AlertGroupDao and AccessTokenDao so the api layer depends only on the repository abstraction. The two mappers are bundled because UsersServiceImpl and ResourcePermissionCheckServiceImpl share both.
AlertGroupDao preserves the mapper's custom ORDER BY update_time DESC in queryAllGroupList (cannot be replaced with IDao.queryAll). existGroupName returns primitive boolean via Boolean.TRUE.equals so callers drop the == Boolean.TRUE dance.
AccessTokenDao renames mapper.selectAccessTokenPage to queryAccessTokenPage and mapper.deleteAccessTokenByUserId to deleteByUserId. updateById in AccessTokenServiceImpl switches from int to boolean so the guard becomes !success instead of i <= 0.
AlertGroupControllerTest.clear() replaces the BaseMapper.delete(QueryWrapper) idiom with a queryAllGroupList stream + deleteById loop so the controller test can stop reaching into MyBatis-Plus internals.
Tracking issue: #18249
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md