[Fix-18269][Master] Move LogicFakeTask to test scope#18270
Merged
Conversation
ruanwenjun
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
ruanwenjun
force-pushed
the
codex/logic-fake-task-test-scope
branch
from
71b20e6 to
3567e46
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES. The code change, verification, and PR description were assisted by OpenAI Codex.
Purpose of the pull request
Close #18269.
LogicFakeTaskis intended only for master integration tests, but it was compiled from production source sets and registered as a production task type. This pull request moves the fake task implementation and related plugin code to test scope so it is no longer packaged into production binaries.Brief change log
LogicFakeTask,LogicFakeTaskPluginFactory,LogicFakeTaskChannel,LogicFakeTaskChannelFactory, andLogicFakeTaskParametersintodolphinscheduler-mastertest sources.@AutoService(TaskChannelFactory.class).TaskPluginManagercannot loadLogicFakeTask.Verify this pull request
This change added tests and can be verified as follows:
./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-api -Dtest=TaskPluginManagerTest -Djacoco.skip=true test./mvnw -pl dolphinscheduler-master -Dtest=WorkflowStartBasicTestCase#testStartWorkflow_with_oneSuccessTask -Djacoco.skip=true clean testPull Request Notice
Pull Request Notice
This pull request does not contain incompatible changes.