[Fix-18276][API] Fix alert plugin instance permission check#18279
Merged
SbloodyS merged 1 commit intoMay 22, 2026
Merged
Conversation
Filter alert plugin instances through authorized alert plugin definitions and push instance checks down to SQL to avoid loading all instances in memory.
|
Member
Author
|
Since the current alert group instances lack user information, it is not possible to implement more granular permission management. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Was this PR generated or assisted by AI?
YES. The implementation and tests were assisted by OpenAI Codex, then reviewed and verified locally.
Purpose of the pull request
Fixes #18276.
Fix alert plugin instance permission checks so alert plugin instance APIs consistently validate the current user's operation-level permission before returning alert plugin instance data.
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
./mvnw -pl dolphinscheduler-api -am -DskipITs -DskipTests=false -Dsurefire.failIfNoSpecifiedTests=false -Djacoco.skip=true -Dtest=AlertPluginInstanceServiceTest,AlertPluginInstanceControllerTest test./mvnw -pl dolphinscheduler-api -am -DskipITs -DskipTests=false -Dsurefire.failIfNoSpecifiedTests=false -Djacoco.skip=true -Dtest=AlertPluginInstanceResourcePermissionCheckTest test./mvnw -pl dolphinscheduler-dao -am -DskipITs -DskipTests=false -Dsurefire.failIfNoSpecifiedTests=false -Djacoco.skip=true -Dtest=AlertPluginInstanceMapperTest testgit diff --checkPull Request Notice
Pull Request Notice