[Fix-18302][Common] Fix SQL license header parsing#18301
Merged
Conversation
ruanwenjun
approved these changes
May 28, 2026
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
LGTM, please create a issue.
hiSandog
changed the title
Contributor
Author
|
Created #18302 and linked it from the PR title/body with |
ruanwenjun
force-pushed
the
fix/sql-license-parser-20260528
branch
from
3c4fe08 to
13f8c8f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Close #18302.
ClasspathSqlScriptParserskips the initial block license header before parsing SQL resources. The closing marker check used the raw line, so a standard indented closing marker like*/was not recognized and the parser could skip the rest of the file.Brief change log
*/marker while skipping the license header.ClasspathSqlScriptParserTest.Verify this pull request
git diff --cached --check./mvnw -pl dolphinscheduler-common -Dtest=ClasspathSqlScriptParserTest testbecause this machine has no Java Runtime available (java -versionreports: Unable to locate a Java Runtime).