[Fix-16617][Seatunnel] Use master option for engine deploy mode#18315
Open
JinRudy wants to merge 2 commits into
Open
[Fix-16617][Seatunnel] Use master option for engine deploy mode#18315JinRudy wants to merge 2 commits into
JinRudy wants to merge 2 commits into
Conversation
- 将 SeaTunnel Engine 部署模式参数改为 --master - 添加 seatunnel.sh 命令参数回归测试
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
SbloodyS
reviewed
Jun 3, 2026
| public List<String> buildOptions() throws Exception { | ||
| List<String> args = super.buildOptions(); | ||
| if (!Objects.isNull(seatunnelParameters.getDeployMode())) { | ||
| args.add(Constants.DEPLOY_MODE_OPTIONS); |
Member
There was a problem hiding this comment.
You should remove Constants.DEPLOY_MODE_OPTIONS since it's useless.
Author
There was a problem hiding this comment.
Addressed in 935c4b6 by removing Constants.DEPLOY_MODE_OPTIONS and inlining the Spark task --deploy-mode argument to preserve the existing Spark command behavior.
SbloodyS
added
first time contributor
- 删除 Seatunnel 公共常量中的 DEPLOY_MODE_OPTIONS - 保留 Spark 任务原有 deploy-mode 参数行为
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #16617.
SeaTunnel 2.3.1 deprecated
-e/--deploy-modeforseatunnel.shand recommends-m/--masterinstead. DolphinScheduler still generated--deploy-modefor the SeaTunnel engine task, which can fail with newer SeaTunnel versions.Changes
Constants.MASTER_OPTIONSwhen building SeaTunnel engine deploy mode arguments.seatunnel.shcommand option generation.Tests
JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel -am -Dtest=SeatunnelTaskTest#testSeatunnelEngineDeployModeUsesMasterOption -Dsurefire.failIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Dspotless.skip=true -Danalyze.skip=true -Djacoco.skip=true -DskipDepCheck=true testJAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel -am -Dtest=SeatunnelTaskTest,SeatunnelParametersTest -Dsurefire.failIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Dspotless.skip=true -Danalyze.skip=true -Djacoco.skip=true -DskipDepCheck=true testJAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel -DskipTests -Djacoco.skip=true -DskipDepCheck=true spotless:checkgit diff --check