-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix](StoragePolicy) fix modify partition's storage policy with different resource issue succeed with execption #35421
Open
Johnnyssc
wants to merge
3
commits into
apache:master
Choose a base branch
from
Johnnyssc:ssc_fix_modify_storage_policy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39925 ms
|
TPC-DS: Total hot run time: 172206 ms
|
ClickBench: Total hot run time: 30.11 s
|
7e12d65
to
c564f36
Compare
run buildall |
TPC-H: Total hot run time: 41841 ms
|
TPC-DS: Total hot run time: 172252 ms
|
ClickBench: Total hot run time: 30.75 s
|
run p0 |
382f8cb
to
cd02604
Compare
run buildall |
TPC-H: Total hot run time: 40857 ms
|
TPC-DS: Total hot run time: 169049 ms
|
ClickBench: Total hot run time: 30.43 s
|
run p0 |
3bf5f90
to
caec0ae
Compare
run buildall |
TPC-H: Total hot run time: 39944 ms
|
TPC-DS: Total hot run time: 171946 ms
|
ClickBench: Total hot run time: 30.78 s
|
run p0 |
caec0ae
to
bb0a155
Compare
run buildall |
bb0a155
to
af23096
Compare
run buildall |
run p0 |
TPC-H: Total hot run time: 40807 ms
|
TPC-DS: Total hot run time: 169444 ms
|
ClickBench: Total hot run time: 31.06 s
|
67e447d
to
35d0924
Compare
run buildall |
TPC-H: Total hot run time: 40561 ms
|
TPC-DS: Total hot run time: 171916 ms
|
ClickBench: Total hot run time: 30.91 s
|
691e20e
to
beb1889
Compare
TPC-H: Total hot run time: 39685 ms
|
TPC-DS: Total hot run time: 174023 ms
|
ClickBench: Total hot run time: 30.49 s
|
…ucceed with execption
beb1889
to
a007707
Compare
run buildall |
TPC-H: Total hot run time: 39691 ms
|
TPC-DS: Total hot run time: 173440 ms
|
ClickBench: Total hot run time: 30.24 s
|
run cloud_p1 |
run cloud_p0 |
run buildall |
TPC-H: Total hot run time: 39731 ms
|
TPC-DS: Total hot run time: 197098 ms
|
ClickBench: Total hot run time: 33.3 s
|
run p0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #34229
when we try to modify a partition's storage policy which have different resource with the previous one, we get error message "currently do not support change origin storage policy to another one with different resource", but the modification same also succeed!
expect:
the modification fail with "currently do not support change origin storage policy to another one with different resource".
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...