[fix] (inverted index ) fix inverted index queries in AGG and MOR table #38371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
xiaokang
reviewed
Jul 28, 2024
| std::string {InvertedIndexDescriptor::get_index_file_path_prefix( | ||
| file_writer->path().c_str())}, | ||
| std::string { | ||
| InvertedIndexDescriptor::get_index_file_path_prefix(segment_file_path)}, |
| @@ -233,7 +233,9 @@ Status BlockReader::init(const ReaderParams& read_params) { | |||
| } | |||
| return status; | |||
| } | |||
|
|
|||
| if (size_t cols = _next_row.block->columns() - _return_columns_loc.size() > 0; cols > 0) { | |||
There was a problem hiding this comment.
It not a common style to write multiple statements in if.
| @@ -97,6 +97,10 @@ class BlockReader final : public TabletReader { | |||
| std::vector<int> _normal_columns_idx; // key column on agg mode, all column on uniq mode | |||
| std::vector<int> _agg_columns_idx; | |||
| std::vector<int> _return_columns_loc; | |||
| // before reading the segment, some expressions will compute results through the index to generate result columns | |||
| // retain this result column when calculating the agg value | |||
| int _index_result_columns = 0; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
On AGG and MOR tables, the key columns are copied first, then the value columns are aggregated.
The result columns from the inverted index computation should be retained.
Issue Number: close #xxx