Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](boolean) fix cast decimal/*int/string as boolean overflow error #38786

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fix](boolean) fix cast decimal/*int/string as boolean overflow error #38786

wants to merge 2 commits into from
+9 −2

Conversation

nextdreamblue
Copy link
Contributor

@nextdreamblue nextdreamblue commented Aug 2, 2024 •
edited
Loading

Proposed changes

Issue Number: close #38788

cast value as boolean to 0/1

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@nextdreamblue
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41719 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e5dfcce8c5ef9cbc1f048ebbcbadb82660a757ac, data reload: false

------ Round 1 ----------------------------------
q1	17602	4366	4132	4132
q2	2038	196	196	196
q3	10550	1280	1328	1280
q4	10246	811	914	811
q5	7651	3025	2997	2997
q6	222	136	136	136
q7	1067	615	611	611
q8	9440	1891	1966	1891
q9	8444	6599	6666	6599
q10	8716	3876	3856	3856
q11	428	251	246	246
q12	413	225	224	224
q13	17757	2928	2919	2919
q14	272	239	241	239
q15	513	481	492	481
q16	531	403	384	384
q17	982	914	902	902
q18	8162	7318	7225	7225
q19	2354	1234	1222	1222
q20	568	320	335	320
q21	5333	4845	4770	4770
q22	352	280	278	278
Total cold run time: 113641 ms
Total hot run time: 41719 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4165	4052	4047	4047
q2	323	219	217	217
q3	3003	3092	3175	3092
q4	2019	2032	1983	1983
q5	5641	5491	5422	5422
q6	219	129	133	129
q7	2150	1849	1812	1812
q8	3338	3353	3357	3353
q9	8626	8766	8772	8766
q10	3973	3952	3947	3947
q11	572	482	463	463
q12	784	627	630	627
q13	16204	3105	3090	3090
q14	313	262	274	262
q15	537	497	482	482
q16	463	422	424	422
q17	1782	1766	1740	1740
q18	8187	7811	7689	7689
q19	1722	1720	1742	1720
q20	2097	1831	1801	1801
q21	5719	5512	5181	5181
q22	535	481	458	458
Total cold run time: 72372 ms
Total hot run time: 56703 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169544 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e5dfcce8c5ef9cbc1f048ebbcbadb82660a757ac, data reload: false

query1	932	388	372	372
query2	6467	1675	1666	1666
query3	6653	215	226	215
query4	19205	17526	17343	17343
query5	3620	529	510	510
query6	276	171	164	164
query7	4597	294	302	294
query8	256	195	191	191
query9	8517	2346	2337	2337
query10	425	286	262	262
query11	10441	10017	10151	10017
query12	115	91	85	85
query13	1631	383	368	368
query14	9113	6840	6886	6840
query15	206	156	165	156
query16	6781	444	462	444
query17	963	555	536	536
query18	1861	276	273	273
query19	184	141	139	139
query20	94	83	83	83
query21	202	100	97	97
query22	4111	3969	4028	3969
query23	33679	33545	33774	33545
query24	9250	3179	3093	3093
query25	683	426	443	426
query26	1210	154	154	154
query27	2594	293	295	293
query28	7367	2016	2002	2002
query29	993	463	447	447
query30	242	158	162	158
query31	974	824	772	772
query32	108	54	61	54
query33	672	329	342	329
query34	914	512	520	512
query35	887	763	757	757
query36	1151	894	878	878
query37	179	79	81	79
query38	2872	2812	2886	2812
query39	870	819	831	819
query40	203	114	112	112
query41	46	43	46	43
query42	123	103	99	99
query43	493	417	423	417
query44	1190	744	748	744
query45	209	177	176	176
query46	1084	815	790	790
query47	1805	1702	1698	1698
query48	364	301	296	296
query49	852	416	449	416
query50	878	435	435	435
query51	6802	6727	6690	6690
query52	102	89	87	87
query53	250	183	179	179
query54	627	456	454	454
query55	77	75	75	75
query56	266	262	259	259
query57	1150	1062	1020	1020
query58	274	255	270	255
query59	2485	2413	2257	2257
query60	287	270	266	266
query61	98	100	97	97
query62	882	663	654	654
query63	216	179	181	179
query64	4851	1908	1889	1889
query65	3172	3069	3086	3069
query66	956	320	335	320
query67	15353	14732	14749	14732
query68	7460	575	589	575
query69	690	383	321	321
query70	1123	1049	1063	1049
query71	460	283	283	283
query72	7653	2677	2543	2543
query73	933	331	332	331
query74	6039	5605	5646	5605
query75	3817	2762	2731	2731
query76	5107	1281	1297	1281
query77	721	320	310	310
query78	9543	8999	8905	8905
query79	1863	536	531	531
query80	1184	502	530	502
query81	518	230	227	227
query82	729	132	130	130
query83	200	169	169	169
query84	256	79	77	77
query85	1276	340	301	301
query86	443	301	307	301
query87	3290	3089	3130	3089
query88	3044	2497	2484	2484
query89	400	296	291	291
query90	1805	194	192	192
query91	124	103	168	103
query92	59	53	50	50
query93	3203	617	614	614
query94	740	286	300	286
query95	389	266	259	259
query96	619	281	300	281
query97	3208	3083	3030	3030
query98	213	203	199	199
query99	1679	1312	1295	1295
Total cold run time: 265178 ms
Total hot run time: 169544 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.24 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e5dfcce8c5ef9cbc1f048ebbcbadb82660a757ac, data reload: false

query1	0.04	0.05	0.04
query2	0.08	0.03	0.04
query3	0.23	0.04	0.04
query4	1.67	0.06	0.07
query5	0.48	0.48	0.49
query6	1.14	0.71	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.58	0.50	0.53
query10	0.56	0.56	0.56
query11	0.16	0.12	0.12
query12	0.15	0.12	0.13
query13	0.60	0.60	0.60
query14	0.78	0.79	0.80
query15	0.93	0.86	0.87
query16	0.36	0.36	0.36
query17	1.01	1.02	0.99
query18	0.22	0.21	0.21
query19	1.83	1.74	1.76
query20	0.01	0.01	0.02
query21	15.42	0.75	0.66
query22	3.82	7.25	1.51
query23	18.08	1.36	1.26
query24	2.29	0.22	0.22
query25	0.18	0.08	0.08
query26	0.32	0.21	0.22
query27	0.47	0.23	0.24
query28	13.17	1.00	0.96
query29	12.54	3.41	3.35
query30	0.26	0.06	0.05
query31	2.85	0.40	0.39
query32	3.23	0.48	0.48
query33	2.92	2.98	2.94
query34	15.44	4.26	4.24
query35	4.29	4.29	4.35
query36	0.68	0.49	0.49
query37	0.19	0.16	0.17
query38	0.17	0.15	0.15
query39	0.04	0.04	0.04
query40	0.15	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.04	0.04
query43	0.06	0.04	0.04
Total cold run time: 107.63 s
Total hot run time: 30.24 s

@nextdreamblue
Copy link
Contributor Author

run buildall

1 similar comment
@nextdreamblue
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41815 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 22aae65cce8ec4196a96e3bb0e444ac26d7238ba, data reload: false

------ Round 1 ----------------------------------
q1	18175	4220	4182	4182
q2	2956	208	210	208
q3	11513	1421	1397	1397
q4	11656	865	960	865
q5	7917	2926	2991	2926
q6	219	141	140	140
q7	1057	614	614	614
q8	9466	1842	1977	1842
q9	8477	6641	6633	6633
q10	8746	3868	3840	3840
q11	421	252	249	249
q12	410	234	227	227
q13	17758	2933	2949	2933
q14	269	246	246	246
q15	532	496	476	476
q16	482	391	385	385
q17	981	922	904	904
q18	7982	7296	7197	7197
q19	1498	1226	1216	1216
q20	583	313	341	313
q21	5359	4818	4743	4743
q22	354	286	279	279
Total cold run time: 116811 ms
Total hot run time: 41815 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4103	3997	4037	3997
q2	323	213	216	213
q3	3023	2987	3004	2987
q4	1886	1879	1849	1849
q5	5281	5252	5221	5221
q6	219	129	133	129
q7	2060	1646	1684	1646
q8	3196	3314	3271	3271
q9	8288	8304	8317	8304
q10	3806	3834	3837	3834
q11	541	451	449	449
q12	720	528	548	528
q13	14838	2951	2936	2936
q14	283	253	249	249
q15	519	477	478	477
q16	441	416	398	398
q17	1739	1708	1704	1704
q18	7624	7334	7226	7226
q19	1690	1673	1682	1673
q20	1983	1765	1735	1735
q21	5455	5113	5257	5113
q22	536	444	455	444
Total cold run time: 68554 ms
Total hot run time: 54383 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168375 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 22aae65cce8ec4196a96e3bb0e444ac26d7238ba, data reload: false

query1	911	374	360	360
query2	6482	1709	1685	1685
query3	6663	213	217	213
query4	19931	17464	17240	17240
query5	4293	528	525	525
query6	293	179	168	168
query7	4612	300	297	297
query8	263	198	198	198
query9	8481	2379	2356	2356
query10	456	280	264	264
query11	10529	10048	10211	10048
query12	140	88	91	88
query13	1649	377	378	377
query14	9305	7581	7111	7111
query15	205	161	168	161
query16	7068	464	412	412
query17	936	548	551	548
query18	1905	274	289	274
query19	184	148	140	140
query20	88	82	87	82
query21	201	99	98	98
query22	4120	4114	3927	3927
query23	33673	32893	33024	32893
query24	10288	3103	3075	3075
query25	679	374	383	374
query26	1759	146	152	146
query27	2931	272	275	272
query28	6936	1972	1964	1964
query29	1287	410	418	410
query30	289	151	150	150
query31	932	715	751	715
query32	99	52	55	52
query33	696	309	310	309
query34	919	477	480	477
query35	864	750	743	743
query36	1022	855	855	855
query37	287	77	79	77
query38	2870	2756	2727	2727
query39	865	793	783	783
query40	284	114	112	112
query41	51	44	45	44
query42	127	101	126	101
query43	461	417	440	417
query44	1195	736	722	722
query45	205	178	176	176
query46	1081	829	785	785
query47	1804	1725	1712	1712
query48	354	292	290	290
query49	1188	422	427	422
query50	908	429	433	429
query51	6755	6696	6609	6609
query52	97	96	90	90
query53	254	181	184	181
query54	640	454	455	454
query55	77	74	75	74
query56	291	266	272	266
query57	1178	1051	1045	1045
query58	283	275	264	264
query59	2584	2365	2386	2365
query60	305	273	313	273
query61	97	91	110	91
query62	900	667	656	656
query63	214	181	185	181
query64	5931	1909	1875	1875
query65	3161	3076	3111	3076
query66	1450	337	332	332
query67	15175	14811	14617	14617
query68	4287	551	577	551
query69	451	360	307	307
query70	1128	1035	1055	1035
query71	424	282	298	282
query72	7120	2648	2524	2524
query73	759	333	325	325
query74	5984	5621	5642	5621
query75	3411	2732	2768	2732
query76	2530	1204	1239	1204
query77	447	313	306	306
query78	9375	8948	8891	8891
query79	1682	532	531	531
query80	1225	495	496	495
query81	579	225	226	225
query82	1046	126	130	126
query83	243	168	174	168
query84	269	86	89	86
query85	1285	314	314	314
query86	388	292	306	292
query87	3273	3125	3078	3078
query88	2976	2445	2432	2432
query89	383	293	293	293
query90	1785	200	193	193
query91	125	104	98	98
query92	63	50	48	48
query93	1522	624	616	616
query94	873	294	290	290
query95	393	269	267	267
query96	609	279	280	279
query97	3223	3043	3080	3043
query98	213	203	196	196
query99	1632	1274	1284	1274
Total cold run time: 261864 ms
Total hot run time: 168375 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.18 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 22aae65cce8ec4196a96e3bb0e444ac26d7238ba, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.04
query4	1.69	0.07	0.07
query5	0.54	0.49	0.49
query6	1.13	0.72	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.58	0.51	0.50
query10	0.58	0.59	0.56
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.61	0.61	0.60
query14	0.77	0.81	0.79
query15	0.91	0.86	0.86
query16	0.36	0.36	0.36
query17	0.97	0.98	1.01
query18	0.22	0.21	0.21
query19	1.84	1.72	1.77
query20	0.01	0.00	0.01
query21	15.42	0.73	0.64
query22	3.92	8.46	1.34
query23	17.89	1.47	1.36
query24	2.29	0.21	0.22
query25	0.18	0.09	0.08
query26	0.32	0.22	0.21
query27	0.46	0.25	0.23
query28	13.17	1.00	0.98
query29	12.53	3.36	3.38
query30	0.26	0.06	0.06
query31	2.88	0.41	0.41
query32	3.22	0.48	0.47
query33	2.92	2.98	2.93
query34	15.45	4.27	4.28
query35	4.29	4.29	4.29
query36	0.67	0.48	0.49
query37	0.19	0.16	0.17
query38	0.16	0.16	0.15
query39	0.04	0.04	0.04
query40	0.16	0.14	0.13
query41	0.10	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 107.56 s
Total hot run time: 30.18 s

@nextdreamblue
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@nextdreamblue
Copy link
Contributor Author

run performance

1 similar comment
@nextdreamblue
Copy link
Contributor Author

run performance

@nextdreamblue
Copy link
Contributor Author

run buildall

1 similar comment
@nextdreamblue
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

  • regression-test/data/load_p0/stream_load/test_stream_load_properties.out
  • regression-test/data/load_p2/routine_load/test_routine_load.out

Consider using git-lfs to manage large files.

@github-actions github-actions bot added the lfs-detected! Warning Label for use when LFS is detected in the commits of a Pull Request label Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

  • regression-test/data/load_p0/stream_load/test_stream_load_properties.out
  • regression-test/data/load_p2/routine_load/test_routine_load.out

Consider using git-lfs to manage large files.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41689 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 07da01bf0bdd3356ec20d516fad2998941976acc, data reload: false

------ Round 1 ----------------------------------
q1	17617	4161	4080	4080
q2	2027	199	199	199
q3	10465	1319	1344	1319
q4	10171	889	958	889
q5	7666	2957	3008	2957
q6	224	135	136	135
q7	1078	643	612	612
q8	9469	1789	1959	1789
q9	8553	6592	6620	6592
q10	8757	3815	3843	3815
q11	430	241	246	241
q12	406	234	232	232
q13	17760	2939	2940	2939
q14	280	245	238	238
q15	521	476	504	476
q16	526	387	379	379
q17	987	925	889	889
q18	8098	7288	7213	7213
q19	1495	1231	1220	1220
q20	568	349	347	347
q21	5434	4847	4910	4847
q22	355	281	285	281
Total cold run time: 112887 ms
Total hot run time: 41689 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4075	4012	4004	4004
q2	330	220	219	219
q3	3010	3047	3171	3047
q4	2032	2072	1981	1981
q5	5593	5498	5475	5475
q6	218	129	131	129
q7	2148	1844	1843	1843
q8	3334	3363	3413	3363
q9	8679	8711	8807	8711
q10	3972	3969	3960	3960
q11	555	476	473	473
q12	760	608	594	594
q13	15100	3112	3104	3104
q14	308	261	281	261
q15	529	515	493	493
q16	484	413	425	413
q17	1789	1728	1723	1723
q18	8359	7848	7694	7694
q19	1761	1722	1759	1722
q20	2069	1859	1840	1840
q21	5758	5415	5450	5415
q22	526	452	459	452
Total cold run time: 71389 ms
Total hot run time: 56916 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168918 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 07da01bf0bdd3356ec20d516fad2998941976acc, data reload: false

query1	930	383	379	379
query2	6487	1657	1648	1648
query3	6654	213	220	213
query4	19145	17318	17303	17303
query5	3663	535	509	509
query6	293	185	184	184
query7	4604	306	303	303
query8	268	199	205	199
query9	8525	2349	2333	2333
query10	418	294	285	285
query11	10495	10105	9992	9992
query12	123	93	87	87
query13	1676	381	358	358
query14	9283	6453	7558	6453
query15	214	162	159	159
query16	6979	469	421	421
query17	958	572	540	540
query18	1926	276	318	276
query19	197	145	140	140
query20	89	90	85	85
query21	204	97	94	94
query22	4233	3976	3949	3949
query23	33862	34037	33657	33657
query24	10292	3180	3189	3180
query25	672	433	424	424
query26	1723	156	161	156
query27	3213	294	292	292
query28	7522	2012	1989	1989
query29	1274	441	462	441
query30	235	154	156	154
query31	991	790	773	773
query32	106	64	60	60
query33	693	334	326	326
query34	947	495	514	495
query35	903	758	768	758
query36	1037	903	898	898
query37	298	87	91	87
query38	2902	2766	2749	2749
query39	888	825	810	810
query40	249	118	114	114
query41	48	46	46	46
query42	125	100	106	100
query43	475	420	408	408
query44	1188	725	741	725
query45	222	182	183	182
query46	1086	814	806	806
query47	1815	1724	1757	1724
query48	366	290	283	283
query49	942	426	432	426
query50	898	447	448	447
query51	6794	6722	6550	6550
query52	104	93	91	91
query53	257	192	186	186
query54	616	463	455	455
query55	77	72	75	72
query56	273	264	254	254
query57	1141	1046	1048	1046
query58	268	271	281	271
query59	2590	2279	2392	2279
query60	294	286	271	271
query61	102	96	96	96
query62	863	654	661	654
query63	213	182	185	182
query64	5690	1900	1890	1890
query65	3160	3116	3093	3093
query66	1307	339	341	339
query67	15302	14624	14678	14624
query68	4305	553	582	553
query69	452	306	292	292
query70	1185	1074	1049	1049
query71	363	286	281	281
query72	7032	2745	2474	2474
query73	767	330	334	330
query74	6016	5632	5725	5632
query75	3367	2731	2729	2729
query76	2147	1220	1284	1220
query77	420	309	318	309
query78	9456	8846	8846	8846
query79	1907	542	533	533
query80	1157	563	505	505
query81	558	225	226	225
query82	1053	146	131	131
query83	231	169	169	169
query84	260	80	88	80
query85	1286	331	336	331
query86	460	347	310	310
query87	3267	3112	3097	3097
query88	2958	2424	2392	2392
query89	383	298	290	290
query90	1684	195	196	195
query91	129	102	107	102
query92	66	51	54	51
query93	1961	622	614	614
query94	832	301	302	301
query95	386	272	272	272
query96	601	281	284	281
query97	3242	3042	3044	3042
query98	239	204	205	204
query99	1633	1305	1310	1305
Total cold run time: 261190 ms
Total hot run time: 168918 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.64 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 07da01bf0bdd3356ec20d516fad2998941976acc, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.04	0.04
query4	1.68	0.06	0.06
query5	0.50	0.48	0.48
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.59	0.52	0.52
query10	0.57	0.58	0.56
query11	0.16	0.12	0.12
query12	0.14	0.12	0.12
query13	0.62	0.61	0.60
query14	0.77	0.79	0.79
query15	0.90	0.86	0.86
query16	0.35	0.36	0.36
query17	0.99	0.99	1.01
query18	0.22	0.21	0.21
query19	1.81	1.76	1.74
query20	0.01	0.00	0.00
query21	15.39	0.75	0.65
query22	3.66	5.74	2.01
query23	17.99	1.27	1.28
query24	2.20	0.22	0.21
query25	0.19	0.08	0.08
query26	0.31	0.21	0.22
query27	0.46	0.24	0.23
query28	13.16	0.99	0.97
query29	12.53	3.29	3.27
query30	0.26	0.06	0.05
query31	2.87	0.41	0.40
query32	3.25	0.48	0.48
query33	2.93	2.92	2.98
query34	15.47	4.24	4.24
query35	4.28	4.26	4.29
query36	0.70	0.49	0.48
query37	0.18	0.17	0.16
query38	0.17	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.13	0.14
query41	0.10	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 107.27 s
Total hot run time: 30.64 s

@nextdreamblue
Copy link
Contributor Author

run cloud_p1

1 similar comment
@nextdreamblue
Copy link
Contributor Author

run cloud_p1

@doris-robot
Copy link

TPC-H: Total hot run time: 39293 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 07da01bf0bdd3356ec20d516fad2998941976acc, data reload: false

------ Round 1 ----------------------------------
q1	17938	4482	4295	4295
q2	2020	190	170	170
q3	10538	1195	1038	1038
q4	10172	751	654	654
q5	7523	2580	2533	2533
q6	226	137	141	137
q7	971	590	593	590
q8	9226	1913	1932	1913
q9	8730	6557	6539	6539
q10	7052	2182	2211	2182
q11	458	251	244	244
q12	419	217	215	215
q13	17774	3001	2974	2974
q14	286	233	235	233
q15	532	480	494	480
q16	498	385	383	383
q17	989	742	707	707
q18	8199	7472	7443	7443
q19	2353	1146	1041	1041
q20	665	338	328	328
q21	5599	4557	4192	4192
q22	1108	1002	1013	1002
Total cold run time: 113276 ms
Total hot run time: 39293 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4494	4241	4265	4241
q2	371	270	271	270
q3	2840	2620	2587	2587
q4	1949	1713	1690	1690
q5	5635	5618	5557	5557
q6	228	132	134	132
q7	2168	1734	1747	1734
q8	3355	3518	3429	3429
q9	8820	8768	8830	8768
q10	3573	3322	3279	3279
q11	579	495	512	495
q12	870	667	619	619
q13	15771	3061	3226	3061
q14	331	304	280	280
q15	543	498	492	492
q16	497	438	444	438
q17	1847	1543	1553	1543
q18	8129	7838	7778	7778
q19	1819	1542	1568	1542
q20	2112	1885	1876	1876
q21	10251	5445	5476	5445
q22	1156	1041	997	997
Total cold run time: 77338 ms
Total hot run time: 56253 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 204304 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 07da01bf0bdd3356ec20d516fad2998941976acc, data reload: false

query1	945	425	398	398
query2	6449	2075	1933	1933
query3	6631	207	220	207
query4	34176	23327	23112	23112
query5	3659	499	492	492
query6	264	172	173	172
query7	4580	298	292	292
query8	252	207	212	207
query9	8718	2405	2361	2361
query10	973	897	977	897
query11	15429	14939	14968	14939
query12	133	97	100	97
query13	1650	388	377	377
query14	8987	8278	8006	8006
query15	361	333	331	331
query16	7788	484	509	484
query17	1723	590	552	552
query18	2049	412	405	405
query19	276	225	220	220
query20	125	112	114	112
query21	210	105	108	105
query22	4708	4395	4382	4382
query23	34211	33819	33854	33819
query24	8542	2972	2816	2816
query25	604	377	381	377
query26	692	162	159	159
query27	2070	295	297	295
query28	5578	2028	2014	2014
query29	755	395	407	395
query30	264	152	154	152
query31	993	732	742	732
query32	90	56	58	56
query33	595	281	283	281
query34	885	475	499	475
query35	956	906	862	862
query36	1076	941	895	895
query37	139	83	79	79
query38	4267	4176	4052	4052
query39	1431	1379	1406	1379
query40	193	116	114	114
query41	48	43	43	43
query42	123	97	101	97
query43	517	455	469	455
query44	1075	740	735	735
query45	404	386	384	384
query46	1127	776	779	776
query47	1824	1759	1759	1759
query48	377	299	300	299
query49	833	423	443	423
query50	803	412	411	411
query51	6727	6659	6654	6654
query52	100	92	94	92
query53	257	186	176	176
query54	717	452	446	446
query55	79	98	73	73
query56	279	245	242	242
query57	1128	1092	1030	1030
query58	223	225	231	225
query59	3013	2769	2828	2769
query60	286	263	261	261
query61	96	95	92	92
query62	785	634	639	634
query63	212	182	184	182
query64	9292	2461	1904	1904
query65	3202	3126	3167	3126
query66	728	327	335	327
query67	15238	14975	14868	14868
query68	5217	579	549	549
query69	419	418	398	398
query70	1185	1070	1119	1070
query71	457	283	280	280
query72	19367	16517	16493	16493
query73	799	325	326	325
query74	9050	8729	8769	8729
query75	3616	2694	2687	2687
query76	3440	1034	976	976
query77	673	308	305	305
query78	9813	10431	9337	9337
query79	7539	509	522	509
query80	937	573	489	489
query81	585	224	226	224
query82	619	141	142	141
query83	179	149	152	149
query84	273	80	82	80
query85	825	293	305	293
query86	453	305	288	288
query87	4601	4655	4522	4522
query88	4419	2480	2507	2480
query89	449	285	297	285
query90	1906	196	197	196
query91	143	119	123	119
query92	63	48	52	48
query93	4472	538	529	529
query94	811	269	299	269
query95	347	254	258	254
query96	616	281	273	273
query97	3228	3069	3056	3056
query98	230	213	208	208
query99	1602	1272	1227	1227
Total cold run time: 311253 ms
Total hot run time: 204304 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.43 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 07da01bf0bdd3356ec20d516fad2998941976acc, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.03
query3	0.22	0.05	0.06
query4	1.68	0.10	0.10
query5	0.50	0.49	0.51
query6	1.13	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.56	0.49	0.49
query10	0.55	0.55	0.54
query11	0.16	0.12	0.12
query12	0.15	0.11	0.13
query13	0.60	0.59	0.58
query14	0.76	0.77	0.77
query15	0.87	0.82	0.81
query16	0.37	0.36	0.37
query17	0.97	0.95	0.95
query18	0.22	0.21	0.22
query19	1.76	1.71	1.70
query20	0.01	0.02	0.02
query21	15.39	0.77	0.65
query22	3.71	8.35	1.81
query23	18.31	1.35	1.30
query24	2.12	0.22	0.21
query25	0.15	0.07	0.08
query26	0.29	0.20	0.20
query27	0.45	0.23	0.22
query28	13.33	1.01	0.99
query29	12.55	3.25	3.26
query30	0.24	0.05	0.04
query31	2.88	0.39	0.39
query32	3.31	0.47	0.47
query33	2.89	2.86	2.87
query34	17.21	4.38	4.37
query35	4.39	4.45	4.41
query36	0.65	0.48	0.48
query37	0.19	0.16	0.15
query38	0.15	0.16	0.14
query39	0.04	0.03	0.04
query40	0.16	0.12	0.13
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.31 s
Total hot run time: 30.43 s

@nextdreamblue
Copy link
Contributor Author

run p1

@nextdreamblue nextdreamblue changed the title [fix](boolean) fix cast as boolean error [fix](boolean) fix cast decimal/*int/string as boolean overflow error Aug 9, 2024
lide-reed
lide-reed previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

xy720
xy720 previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nextdreamblue nextdreamblue dismissed stale reviews from xy720 and lide-reed via a5e347a September 26, 2024 03:09
@nextdreamblue
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed lfs-detected! Warning Label for use when LFS is detected in the commits of a Pull Request approved Indicates a PR has been approved by one committer. labels Sep 26, 2024
lide-reed
lide-reed approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2024
zhiqiang-hhhh
zhiqiang-hhhh suggested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more discuss.

@nextdreamblue
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9626/25813)
Line Coverage: 28.71% (79701/277603)
Region Coverage: 28.13% (41204/146482)
Branch Coverage: 24.76% (20987/84754)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a5e347affe9b06a3b598589301fe4e76bee3292c_a5e347affe9b06a3b598589301fe4e76bee3292c/report/index.html

@nextdreamblue
Copy link
Contributor Author

run cloud_p0

@nextdreamblue
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25912)
Line Coverage: 28.74% (80624/280528)
Region Coverage: 28.19% (41728/148048)
Branch Coverage: 24.76% (21210/85656)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6035f160002ff5715364ff0d269bab11f35b4e78_6035f160002ff5715364ff0d269bab11f35b4e78/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh requested changes

@lide-reed lide-reed lide-reed approved these changes

@xy720 xy720 xy720 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] cast as boolean error
5 participants
@nextdreamblue @doris-robot @lide-reed @xy720 @zhiqiang-hhhh