Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement](user) Support limit user connection by ip #38837

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[enhancement](user) Support limit user connection by ip #38837

wants to merge 8 commits into from

Conversation

stalary
Copy link
Contributor

@stalary stalary commented Aug 4, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

In some cases, multiple services may use a common account, but the service may not be able to control the number of connections well, and we need to restrict it in the doris.

Such as prod and stage environment use common user, but stage database connection use too many due to user connection too many.

This parameter can be used to refine user connection limits.

The use way as follow

SET PROPERTY FOR 'root' 'max_user_ip_connections' = '50';

You can use it control server connect number per ip(such as podIp in k8s) and control it concurrent.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@stalary stalary requested review from zy-kkk and morningman August 6, 2024 02:09
@morningman morningman self-assigned this Aug 6, 2024
@stalary stalary force-pushed the feature-user_ip_connect branch from bd9793c to 2476009 Compare August 11, 2024 10:05
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

morningman
morningman previously approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@stalary stalary force-pushed the feature-user_ip_connect branch from 0e84864 to 52b3b9f Compare August 13, 2024 14:24
@stalary
Copy link
Contributor Author

stalary commented Aug 13, 2024

run buildall

@morningman morningman force-pushed the feature-user_ip_connect branch from 52b3b9f to 294f2c2 Compare August 14, 2024 13:41
@morningman
Copy link
Contributor

run buildall

@morningman morningman force-pushed the feature-user_ip_connect branch from 294f2c2 to 33148a4 Compare August 19, 2024 14:28
@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 21, 2024
wangbo
wangbo previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 22, 2024
@stalary stalary force-pushed the feature-user_ip_connect branch from 5c77903 to 88b36db Compare August 23, 2024 01:56
@stalary
Copy link
Contributor Author

stalary commented Aug 23, 2024

run buildall

@stalary stalary force-pushed the feature-user_ip_connect branch from 88b36db to 82a5e24 Compare August 29, 2024 01:48
@stalary
Copy link
Contributor Author

stalary commented Aug 29, 2024

run buildall

@morningman
Copy link
Contributor

run p0

@github-actions GitHub Actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman left review comments

@wangbo wangbo wangbo left review comments

@zy-kkk zy-kkk Awaiting requested review from zy-kkk

At least 1 approving review is required to merge this pull request.

Assignees

@morningman morningman

Labels
doing reviewed Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stalary @doris-robot @morningman @wangbo