[improvement](mtmv) Support to use view when create mtmv #38882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41386 ms |
TPC-DS: Total hot run time: 168523 ms |
ClickBench: Total hot run time: 30.15 s |
seawinde
force-pushed
the
mv_support_view
branch
from
4048886 to
9e2969a
Compare
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 41413 ms |
TPC-DS: Total hot run time: 168830 ms |
ClickBench: Total hot run time: 30.45 s |
|
run buildall |
TPC-H: Total hot run time: 41677 ms |
TPC-DS: Total hot run time: 168155 ms |
ClickBench: Total hot run time: 29.87 s |
seawinde
force-pushed
the
mv_support_view
branch
from
83a5c59 to
8d87283
Compare
|
run buildall |
TPC-H: Total hot run time: 39571 ms |
TPC-H: Total hot run time: 39419 ms |
TPC-DS: Total hot run time: 204186 ms |
ClickBench: Total hot run time: 30.7 s |
morrySnow
previously approved these changes
Aug 12, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
|
|
if view in mtmv, we always expand the view in analyze. So when query rewrite by materialized view or refresh the materialized view, the view doesn't exist. |
seawinde
force-pushed
the
mv_support_view
branch
2 times, most recently
from
0342422 to
616758f
Compare
seawinde
force-pushed
the
mv_support_view
branch
from
616758f to
6952e6e
Compare
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 38072 ms |
TPC-DS: Total hot run time: 193380 ms |
ClickBench: Total hot run time: 31.83 s |
|
run buildall |
TPC-H: Total hot run time: 38732 ms |
TPC-DS: Total hot run time: 188480 ms |
ClickBench: Total hot run time: 32.29 s |
zddr
reviewed
Aug 29, 2024
| @@ -83,21 +81,30 @@ public static MTMVRelation generateMTMVRelation(MTMV mtmv, ConnectContext ctx) { | |||
| } | |||
|
|
|||
| public static MTMVRelation generateMTMVRelation(Plan plan) { | |||
| return new MTMVRelation(getBaseTables(plan, true), getBaseTables(plan, false), getBaseViews(plan)); | |||
| return new MTMVRelation(getBaseTables(plan, true, true), | |||
| getBaseTables(plan, false, false), getBaseViews(plan)); | |||
There was a problem hiding this comment.
should explandView？otherwise，data change in baseTable,mv will not refresh auto
| @@ -78,7 +78,8 @@ public void initMaterializationContext(CascadesContext cascadesContext) { | |||
| * @param cascadesContext current cascadesContext in the planner | |||
| */ | |||
| protected void doInitMaterializationContext(CascadesContext cascadesContext) { | |||
| TableCollectorContext collectorContext = new TableCollectorContext(Sets.newHashSet(), true); | |||
| TableCollectorContext collectorContext = new TableCollectorContext(Sets.newHashSet(), | |||
| true, true); | |||
There was a problem hiding this comment.
For query plan, this should not extend, we only get avalible mvs by one level table or view. this is for performance
seawinde
force-pushed
the
mv_support_view
branch
from
61faf87 to
07d98d7
Compare
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support to use mv when create async materialized view
Such as view def is as following:
Can create materialized view like following:
CREATE MATERIALIZED VIEW mv1_name BUILD IMMEDIATE REFRESH AUTO ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ( 'replication_num' = '1' ) AS SELECT cnt_1, cnt_2, sum_1, min_1 from view1;