Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cloud) Fix tablet_id is zero when txn lazy commit #42043

Merged
merged 3 commits into from
Oct 28, 2024
Merged

[fix](cloud) Fix tablet_id is zero when txn lazy commit #42043

merged 3 commits into from
Oct 28, 2024

Conversation

SWJTU-ZhangLei
Copy link
Contributor

@SWJTU-ZhangLei SWJTU-ZhangLei commented Oct 17, 2024 •
edited by gavinchou
Loading

  • when recycler and ms convert tmp rowsets at the same times, and finish convert task with different partitions severally, may cause tablet_id variable is zero

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@SWJTU-ZhangLei SWJTU-ZhangLei changed the title [fix](cloud) Fix tablet_id is zere when txn lazy commit [fix](cloud) Fix tablet_id is zero when txn lazy commit Oct 17, 2024
@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou reviewed Oct 24, 2024
View reviewed changes
cloud/src/meta-service/txn_lazy_committer.cpp Outdated
partition_to_tmp_rowset_metas[tmp_rowset_pb.partition_id()].emplace_back();
partition_to_tmp_rowset_metas[tmp_rowset_pb.partition_id()].back().first =
tmp_rowset_key;
partition_to_tmp_rowset_metas[tmp_rowset_pb.partition_id()].back().second =
tmp_rowset_pb;
}

int64_t table_id = -1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one-stream-multi-table load?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one-stream-multi-table load?

done

@SWJTU-ZhangLei
[fix](cloud) Fix tablet_id is zero when txn lazy commit
ba38259 
* when ry and ms convert tmp rowsets at the same times, and finish convert task
  with different partitions severally, may cause tablet_id variable is zero
@SWJTU-ZhangLei
fix some comments
135dff8
@SWJTU-ZhangLei
fix some comments
86cf70d
@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

deardeng
deardeng approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 4bb7139 into apache:master Oct 28, 2024
27 of 29 checks passed
SWJTU-ZhangLei added a commit to SWJTU-ZhangLei/incubator-doris that referenced this pull request Oct 30, 2024
@SWJTU-ZhangLei
[fix](cloud) Fix tablet_id is zero when txn lazy commit (apache#42043)
39cfd72 
* when recycler and ms convert tmp rowsets at the same times, and finish
convert task with different partitions severally, may cause tablet_id
variable is zero
@SWJTU-ZhangLei SWJTU-ZhangLei mentioned this pull request Oct 30, 2024
Merged
dataroaring pushed a commit that referenced this pull request Oct 31, 2024
@SWJTU-ZhangLei
[fix](cloud) Fix tablet_id is zero when txn lazy commit (#42043) (#42905
79b6a99 
)

* when recycler and ms convert tmp rowsets at the same times, and finish
convert task with different partitions severally, may cause tablet_id
variable is zero

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@deardeng deardeng deardeng approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SWJTU-ZhangLei @doris-robot @deardeng @gavinchou @dataroaring