Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env](compile) open compile check in runtime file #42499

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Oct 25, 2024

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Oct 25, 2024

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

return (addr & mask) == (cidr_addr & mask);
}

#if defined(__SSE2__) || defined(__aarch64__)

bool match_ipv6_subnet(const uint8_t* addr, const uint8_t* cidr_addr, uint8_t prefix) {
uint16_t mask = _mm_movemask_epi8(
uint16_t mask = (uint16_t)_mm_movemask_epi8(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]

Suggested change
uint16_t mask = (uint16_t)_mm_movemask_epi8(
auto mask = (uint16_t)_mm_movemask_epi8(

@Mryange
Copy link
Contributor Author

Mryange commented Oct 25, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41468 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a24a2e02bd018f8550e5d048d912980221c36728, data reload: false

------ Round 1 ----------------------------------
q1	17557	7580	7273	7273
q2	2043	292	283	283
q3	12066	1077	1132	1077
q4	10567	883	885	883
q5	7761	3107	3057	3057
q6	233	151	147	147
q7	1033	610	602	602
q8	9355	1954	1972	1954
q9	6607	6453	6445	6445
q10	7042	2427	2467	2427
q11	447	253	249	249
q12	409	219	214	214
q13	17782	2999	3018	2999
q14	239	209	230	209
q15	570	514	521	514
q16	657	596	590	590
q17	975	613	529	529
q18	7479	6823	6623	6623
q19	1331	1042	1017	1017
q20	482	184	181	181
q21	4015	3284	3190	3190
q22	1111	1023	1005	1005
Total cold run time: 109761 ms
Total hot run time: 41468 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7293	7247	7256	7247
q2	326	230	235	230
q3	3065	2971	2974	2971
q4	2074	1824	1775	1775
q5	5786	5793	5760	5760
q6	220	140	143	140
q7	2246	1828	1784	1784
q8	3404	3522	3473	3473
q9	8947	8954	8976	8954
q10	3630	3574	3530	3530
q11	580	494	509	494
q12	805	630	607	607
q13	11028	3182	3239	3182
q14	307	264	279	264
q15	571	529	521	521
q16	684	669	657	657
q17	1865	1645	1602	1602
q18	8404	7811	7722	7722
q19	1720	1510	1587	1510
q20	2145	1854	1909	1854
q21	5539	5489	5386	5386
q22	1182	1054	1022	1022
Total cold run time: 71821 ms
Total hot run time: 60685 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9714/25935)
Line Coverage: 28.71% (80547/280579)
Region Coverage: 28.14% (41656/148043)
Branch Coverage: 24.70% (21172/85704)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a24a2e02bd018f8550e5d048d912980221c36728_a24a2e02bd018f8550e5d048d912980221c36728/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 191381 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a24a2e02bd018f8550e5d048d912980221c36728, data reload: false

query1	850	383	402	383
query2	6265	2193	2191	2191
query3	8681	190	201	190
query4	34469	23592	23575	23575
query5	5163	447	438	438
query6	291	180	167	167
query7	4194	298	299	298
query8	296	246	242	242
query9	9411	2662	2639	2639
query10	480	246	254	246
query11	18390	15319	15197	15197
query12	147	104	97	97
query13	1556	430	413	413
query14	9100	6579	7131	6579
query15	241	170	174	170
query16	7964	477	482	477
query17	1453	588	577	577
query18	2108	335	317	317
query19	231	159	152	152
query20	118	115	117	115
query21	203	109	103	103
query22	4968	4651	4683	4651
query23	34873	34296	33988	33988
query24	8970	2873	2759	2759
query25	603	403	401	401
query26	731	157	160	157
query27	2087	286	288	286
query28	6617	2417	2395	2395
query29	767	429	416	416
query30	262	160	155	155
query31	1048	810	806	806
query32	92	54	54	54
query33	645	268	276	268
query34	906	515	517	515
query35	1015	907	884	884
query36	1089	923	969	923
query37	123	75	77	75
query38	4582	4196	4270	4196
query39	1481	1435	1414	1414
query40	197	101	99	99
query41	47	45	46	45
query42	117	98	96	96
query43	544	482	499	482
query44	1159	819	816	816
query45	181	169	176	169
query46	1133	700	681	681
query47	1914	1867	1891	1867
query48	397	313	318	313
query49	931	385	410	385
query50	836	380	392	380
query51	7161	7093	6881	6881
query52	97	85	85	85
query53	244	181	185	181
query54	845	401	395	395
query55	78	76	76	76
query56	258	228	231	228
query57	1310	1166	1146	1146
query58	209	198	200	198
query59	3216	3048	3024	3024
query60	275	241	247	241
query61	99	101	104	101
query62	827	662	671	662
query63	217	197	184	184
query64	3570	626	632	626
query65	3268	3170	3223	3170
query66	785	293	304	293
query67	16168	15768	15751	15751
query68	4454	560	565	560
query69	439	256	255	255
query70	1183	1124	1205	1124
query71	323	263	252	252
query72	6333	4056	3933	3933
query73	760	362	364	362
query74	10113	8888	9032	8888
query75	3443	2652	2702	2652
query76	2434	948	927	927
query77	371	263	262	262
query78	10663	9565	9555	9555
query79	1381	590	587	587
query80	1036	410	421	410
query81	556	239	238	238
query82	672	116	112	112
query83	236	133	134	133
query84	231	69	68	68
query85	1241	294	279	279
query86	409	302	297	297
query87	4900	4824	4719	4719
query88	3107	2227	2164	2164
query89	403	288	290	288
query90	2011	188	183	183
query91	136	99	96	96
query92	56	46	47	46
query93	1057	533	544	533
query94	914	287	287	287
query95	350	248	252	248
query96	603	277	277	277
query97	2895	2668	2699	2668
query98	212	198	198	198
query99	1635	1320	1296	1296
Total cold run time: 293110 ms
Total hot run time: 191381 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.72 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a24a2e02bd018f8550e5d048d912980221c36728, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.07
query4	1.64	0.10	0.10
query5	0.42	0.40	0.40
query6	1.15	0.66	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.49	0.51
query10	0.55	0.55	0.54
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.60	0.60	0.60
query14	2.84	2.73	2.73
query15	0.89	0.82	0.83
query16	0.42	0.38	0.38
query17	1.03	1.01	1.01
query18	0.20	0.20	0.20
query19	1.86	1.87	2.01
query20	0.01	0.01	0.01
query21	15.35	0.60	0.59
query22	3.22	1.95	1.81
query23	16.90	1.04	0.69
query24	2.70	1.46	1.28
query25	0.26	0.18	0.12
query26	0.40	0.14	0.14
query27	0.03	0.04	0.04
query28	10.56	1.10	1.07
query29	12.59	3.25	3.26
query30	0.25	0.07	0.06
query31	2.88	0.39	0.37
query32	3.27	0.46	0.46
query33	3.03	2.97	3.07
query34	16.88	4.41	4.46
query35	4.52	4.52	4.53
query36	0.65	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.07	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.8 s
Total hot run time: 32.72 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 28, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 51446fb into apache:master Oct 28, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants