Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) offset do more than once when have shuffle after limit #42576

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

morrySnow
Copy link
Contributor

intro by #39316. it want to fix a problem intro by #36699. but forgot to remove all wrong code in #36699.

after #39316, we should not set offset on exchange, when the exchange is on the top of a limit with offset.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 28, 2024
…apache#42576)

pick from master apache#42576

intro by apache#39316. it want to fix a problem intro by apache#36699.
but forgot to remove all wrong code in apache#36699.

after apache#39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
intro by apache#39316. it want to fix a problem intro by apache#36699.
but forgot to remove all wrong code in apache#36699.

after apache#39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 28, 2024
…apache#42576)

pick from master apache#42576

intro by apache#39316. it want to fix a problem intro by apache#36699.
but forgot to remove all wrong code in apache#36699.

after apache#39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
@morrySnow
Copy link
Contributor Author

run buildall

morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 28, 2024
…apache#42576)

pick from master apache#42576

intro by apache#39316. it want to fix a problem intro by apache#36699.
but forgot to remove all wrong code in apache#36699.

after apache#39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 28, 2024
…apache#42576)

pick from master apache#42576

intro by apache#39316. it want to fix a problem intro by apache#36699.
but forgot to remove all wrong code in apache#36699.

after apache#39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 28, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 45d0e01 into apache:master Oct 28, 2024
25 of 27 checks passed
@morrySnow morrySnow deleted the fix_limit branch October 28, 2024 09:39
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 28, 2024
…apache#42576)

pick from master apache#42576

intro by apache#39316. it want to fix a problem intro by apache#36699.
but forgot to remove all wrong code in apache#36699.

after apache#39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
morrySnow added a commit that referenced this pull request Oct 28, 2024
…#42576) (#42577)

pick from master #42576

intro by #39316. it want to fix a problem intro by #36699. but forgot to
remove all wrong code in #36699.

after #39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
morrySnow added a commit that referenced this pull request Oct 29, 2024
…#42576) (#42682)

pick from master #42576

intro by #39316. it want to fix a problem intro by #36699. but forgot to
remove all wrong code in #36699.

after #39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 29, 2024
…apache#42576)

pick from master apache#42576

intro by apache#39316. it want to fix a problem intro by apache#36699.
but forgot to remove all wrong code in apache#36699.

after apache#39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
morrySnow added a commit that referenced this pull request Oct 29, 2024
…#42576) (#42583)

pick from master #42576

intro by #39316. it want to fix a problem intro by #36699. but forgot to
remove all wrong code in #36699.

after #39316, we should not set offset on exchange, when the exchange is
on the top of a limit with offset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants