Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM][misc](bvar) expose file uploading thread pool queue size #43590

Conversation

freemandealer
Copy link
Contributor

What problem does this PR solve?

expose thread pool queue size for better monitoring upload pressure

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • [x ] No need to test or manual test. Explain why:
      • [x ] This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • [x ] No. Just internal info exposure for debug reason
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer freemandealer changed the title [misc](cloud) expose file uploading thread pool queue size [misc](bvar) expose file uploading thread pool queue size Nov 11, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -110,8 +112,14 @@ Status UploadFileBuffer::append_data(const Slice& data) {
*/
static Status submit_upload_buffer(std::shared_ptr<FileBuffer> buffer) {
TEST_SYNC_POINT_RETURN_WITH_VALUE("UploadFileBuffer::submit", Status::OK(), buffer.get());
return ExecEnv::GetInstance()->s3_file_upload_thread_pool()->submit_func(
[buf = std::move(buffer)]() { buf->execute_async(); });
auto pool = ExecEnv::GetInstance()->s3_file_upload_thread_pool();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'auto pool' can be declared as 'auto *pool' [readability-qualified-auto]

Suggested change
auto pool = ExecEnv::GetInstance()->s3_file_upload_thread_pool();
auto *pool = ExecEnv::GetInstance()->s3_file_upload_thread_pool();

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.75% (9815/26003)
Line Coverage: 29.05% (82126/282682)
Region Coverage: 28.16% (42217/149898)
Branch Coverage: 24.74% (21393/86470)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a8e61f806504d8cf7f8967026b7120238e4ffcd6_a8e61f806504d8cf7f8967026b7120238e4ffcd6/report/index.html

@gavinchou gavinchou changed the title [misc](bvar) expose file uploading thread pool queue size [DNM][misc](bvar) expose file uploading thread pool queue size Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants