-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM][misc](bvar) expose file uploading thread pool queue size #43590
[DNM][misc](bvar) expose file uploading thread pool queue size #43590
Conversation
Signed-off-by: zhengyu <[email protected]>
run buildall |
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -110,8 +112,14 @@ Status UploadFileBuffer::append_data(const Slice& data) { | |||
*/ | |||
static Status submit_upload_buffer(std::shared_ptr<FileBuffer> buffer) { | |||
TEST_SYNC_POINT_RETURN_WITH_VALUE("UploadFileBuffer::submit", Status::OK(), buffer.get()); | |||
return ExecEnv::GetInstance()->s3_file_upload_thread_pool()->submit_func( | |||
[buf = std::move(buffer)]() { buf->execute_async(); }); | |||
auto pool = ExecEnv::GetInstance()->s3_file_upload_thread_pool(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'auto pool' can be declared as 'auto *pool' [readability-qualified-auto]
auto pool = ExecEnv::GetInstance()->s3_file_upload_thread_pool(); | |
auto *pool = ExecEnv::GetInstance()->s3_file_upload_thread_pool(); |
TeamCity be ut coverage result: |
What problem does this PR solve?
expose thread pool queue size for better monitoring upload pressure
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)