Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](cast) fix datetime type compare loss scale info #47461

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhangstar333
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32611 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6a7954098a8dd434ce942d2dac0934a50342abec, data reload: false

------ Round 1 ----------------------------------
q1	17603	5477	5379	5379
q2	2054	311	168	168
q3	10415	1222	763	763
q4	10204	985	529	529
q5	7520	2398	2172	2172
q6	191	165	131	131
q7	916	758	610	610
q8	9244	1357	1244	1244
q9	5267	4958	4918	4918
q10	6874	2347	1892	1892
q11	469	292	257	257
q12	359	378	236	236
q13	17833	3817	3226	3226
q14	246	240	230	230
q15	519	493	472	472
q16	609	603	578	578
q17	576	870	321	321
q18	6927	6455	6477	6455
q19	1634	955	563	563
q20	318	316	188	188
q21	2837	2158	1977	1977
q22	374	335	302	302
Total cold run time: 102989 ms
Total hot run time: 32611 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5560	5530	5515	5515
q2	241	323	237	237
q3	2270	2666	2335	2335
q4	1449	1810	1420	1420
q5	4303	4711	4654	4654
q6	167	156	126	126
q7	2049	1958	1806	1806
q8	2636	2848	2722	2722
q9	7357	7177	7248	7177
q10	3063	3293	2805	2805
q11	595	511	489	489
q12	653	744	579	579
q13	3645	3932	3287	3287
q14	280	294	270	270
q15	529	473	501	473
q16	645	689	626	626
q17	1243	1771	1283	1283
q18	7751	7677	7335	7335
q19	858	1144	1107	1107
q20	2018	2041	1919	1919
q21	5779	5183	5120	5120
q22	623	645	582	582
Total cold run time: 53714 ms
Total hot run time: 51867 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192286 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6a7954098a8dd434ce942d2dac0934a50342abec, data reload: false

query1	1336	946	924	924
query2	6185	2005	2010	2005
query3	10973	4519	4443	4443
query4	32758	23656	22904	22904
query5	3873	600	457	457
query6	269	198	195	195
query7	3983	486	325	325
query8	298	247	227	227
query9	9394	2670	2676	2670
query10	452	314	253	253
query11	17625	15140	15109	15109
query12	164	111	104	104
query13	1570	534	425	425
query14	9874	7986	7589	7589
query15	268	222	192	192
query16	7665	665	485	485
query17	1634	781	567	567
query18	1645	417	334	334
query19	200	193	164	164
query20	117	115	119	115
query21	203	122	115	115
query22	4733	4757	4477	4477
query23	34513	33519	33194	33194
query24	6428	2292	2277	2277
query25	510	471	396	396
query26	722	280	151	151
query27	2078	483	330	330
query28	5454	2526	2467	2467
query29	599	556	444	444
query30	218	194	158	158
query31	984	875	824	824
query32	90	61	57	57
query33	480	363	327	327
query34	758	873	507	507
query35	835	865	753	753
query36	1022	1043	972	972
query37	118	124	76	76
query38	4372	4222	4185	4185
query39	1508	1473	1426	1426
query40	207	117	105	105
query41	56	49	51	49
query42	125	103	109	103
query43	514	526	488	488
query44	1427	845	851	845
query45	182	177	172	172
query46	881	1084	656	656
query47	1912	1920	1851	1851
query48	389	404	324	324
query49	720	492	428	428
query50	653	683	400	400
query51	4342	4283	4258	4258
query52	115	112	103	103
query53	237	266	195	195
query54	479	510	430	430
query55	88	79	83	79
query56	267	257	248	248
query57	1196	1220	1136	1136
query58	249	234	223	223
query59	3088	3214	2996	2996
query60	279	271	258	258
query61	115	111	111	111
query62	788	733	651	651
query63	230	200	190	190
query64	3497	1095	648	648
query65	3397	3234	3273	3234
query66	737	387	294	294
query67	16389	15704	15775	15704
query68	2336	839	550	550
query69	461	281	244	244
query70	1217	1194	1154	1154
query71	374	283	251	251
query72	5148	3822	3942	3822
query73	656	748	362	362
query74	9863	9199	8929	8929
query75	3239	3183	2697	2697
query76	2999	1188	762	762
query77	470	375	279	279
query78	10022	10310	9309	9309
query79	2534	826	612	612
query80	1711	517	440	440
query81	559	277	231	231
query82	360	147	116	116
query83	258	164	147	147
query84	236	90	70	70
query85	786	356	312	312
query86	474	314	304	304
query87	4441	4479	4445	4445
query88	4150	2188	2171	2171
query89	395	334	290	290
query90	1748	193	196	193
query91	132	143	107	107
query92	67	55	53	53
query93	2192	888	528	528
query94	696	405	293	293
query95	333	264	257	257
query96	491	623	285	285
query97	2812	2886	2776	2776
query98	221	198	193	193
query99	1318	1351	1302	1302
Total cold run time: 281166 ms
Total hot run time: 192286 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.06% (10970/26082)
Line Coverage: 32.33% (92712/286791)
Region Coverage: 31.48% (47550/151026)
Branch Coverage: 27.53% (24086/87490)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6a7954098a8dd434ce942d2dac0934a50342abec_6a7954098a8dd434ce942d2dac0934a50342abec/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 29.91 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6a7954098a8dd434ce942d2dac0934a50342abec, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.03	0.03
query3	0.24	0.08	0.07
query4	1.62	0.10	0.10
query5	0.42	0.41	0.39
query6	1.17	0.67	0.65
query7	0.02	0.01	0.02
query8	0.05	0.04	0.03
query9	0.59	0.50	0.49
query10	0.55	0.57	0.54
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.63	0.59	0.59
query14	2.79	2.72	2.69
query15	0.90	0.82	0.82
query16	0.38	0.38	0.38
query17	1.04	1.02	0.96
query18	0.22	0.21	0.21
query19	1.96	1.84	2.02
query20	0.02	0.01	0.01
query21	15.38	0.95	0.57
query22	0.75	0.79	0.73
query23	15.20	1.37	0.53
query24	3.39	1.51	0.37
query25	0.18	0.12	0.19
query26	0.35	0.15	0.14
query27	0.05	0.06	0.04
query28	13.63	1.02	0.42
query29	12.58	4.00	3.28
query30	0.25	0.09	0.06
query31	2.83	0.60	0.39
query32	3.23	0.56	0.46
query33	3.10	3.03	3.05
query34	16.75	5.13	4.48
query35	4.50	4.44	4.51
query36	0.66	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.34 s
Total hot run time: 29.91 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants