-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](profile) Fix merge profile failed due to NonZeroCounter #47465
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run buildall |
TPC-H: Total hot run time: 32298 ms
|
TPC-DS: Total hot run time: 184843 ms
|
ClickBench: Total hot run time: 31.04 s
|
we should add some UT in Profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
What problem does this PR solve?
orgCounter could be null if counter structure is changed
change of counter structure happens when NonZeroCounter is involved.
So here we have to ignore the counter if it is not found in the profile.
Related PR: #47070
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)