Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](Nereids) change numeric arithmatic function boundary behavior to match with be execution behavior #47966 #48080

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #47966

…o match with be execution behavior (#47966)

### What problem does this PR solve?

Related PR: #40744#47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
@Thearas
Copy link
Contributor

Thearas commented Feb 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 19, 2025
@Thearas
Copy link
Contributor

Thearas commented Feb 19, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40729 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ca37c4cf96360adae590201e3659f21ab857d136, data reload: false

------ Round 1 ----------------------------------
q1	17596	7365	7191	7191
q2	2068	180	176	176
q3	10557	1044	1203	1044
q4	10584	732	769	732
q5	7737	2841	2756	2756
q6	253	149	147	147
q7	999	600	601	600
q8	9363	1990	2004	1990
q9	6630	6394	6393	6393
q10	7038	2329	2348	2329
q11	486	261	261	261
q12	401	216	213	213
q13	17837	3012	3006	3006
q14	235	227	215	215
q15	575	519	515	515
q16	700	606	597	597
q17	963	639	547	547
q18	7173	6613	6761	6613
q19	1403	1041	1017	1017
q20	507	212	198	198
q21	4022	3236	3250	3236
q22	1094	981	953	953
Total cold run time: 108221 ms
Total hot run time: 40729 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7251	7407	7192	7192
q2	352	234	225	225
q3	2895	2897	2889	2889
q4	2037	1818	1840	1818
q5	5739	5741	5696	5696
q6	225	142	143	142
q7	2301	1830	1866	1830
q8	3350	3483	3572	3483
q9	8774	8845	8823	8823
q10	3595	3601	3555	3555
q11	598	526	495	495
q12	816	616	622	616
q13	9476	3177	3161	3161
q14	307	275	282	275
q15	585	514	519	514
q16	704	648	659	648
q17	1845	1621	1602	1602
q18	8243	7633	7713	7633
q19	1646	1461	1581	1461
q20	2114	1823	1871	1823
q21	5496	5355	5368	5355
q22	1144	1015	1054	1015
Total cold run time: 69493 ms
Total hot run time: 60251 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198286 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ca37c4cf96360adae590201e3659f21ab857d136, data reload: false

query1	1305	932	929	929
query2	6244	2188	2090	2090
query3	10847	4291	4329	4291
query4	66381	29442	23603	23603
query5	5001	448	455	448
query6	409	182	186	182
query7	5547	312	309	309
query8	305	220	217	217
query9	8898	2674	2659	2659
query10	447	262	250	250
query11	17118	14971	16098	14971
query12	156	101	105	101
query13	1466	440	422	422
query14	10535	7365	7696	7365
query15	205	180	197	180
query16	7146	510	489	489
query17	1101	615	597	597
query18	1865	330	327	327
query19	219	163	166	163
query20	120	115	110	110
query21	202	105	109	105
query22	4814	4545	4610	4545
query23	34464	34349	34415	34349
query24	6096	2872	3048	2872
query25	545	425	421	421
query26	660	178	176	176
query27	2017	350	358	350
query28	4554	2477	2484	2477
query29	744	494	436	436
query30	240	161	158	158
query31	987	828	881	828
query32	65	53	54	53
query33	457	289	283	283
query34	918	500	522	500
query35	859	740	718	718
query36	1082	975	971	971
query37	117	75	69	69
query38	4237	4036	4017	4017
query39	1534	1454	1482	1454
query40	194	103	101	101
query41	48	46	48	46
query42	113	101	100	100
query43	538	510	505	505
query44	1201	832	829	829
query45	186	165	171	165
query46	1158	732	719	719
query47	2034	1934	1964	1934
query48	473	386	378	378
query49	723	385	381	381
query50	859	437	432	432
query51	7427	7220	7024	7024
query52	104	85	89	85
query53	258	185	184	184
query54	556	454	459	454
query55	80	81	80	80
query56	256	234	243	234
query57	1228	1128	1116	1116
query58	220	196	200	196
query59	3421	3291	3085	3085
query60	271	255	250	250
query61	113	107	109	107
query62	847	719	729	719
query63	214	184	186	184
query64	1351	670	648	648
query65	3244	3243	3192	3192
query66	692	299	332	299
query67	15847	15745	15703	15703
query68	4122	592	566	566
query69	438	259	261	259
query70	1177	1112	1137	1112
query71	352	257	251	251
query72	6374	3995	3943	3943
query73	776	350	353	350
query74	10526	9114	9078	9078
query75	3343	2622	2651	2622
query76	1896	996	1100	996
query77	553	268	269	268
query78	10614	9585	9598	9585
query79	2189	609	607	607
query80	1450	422	417	417
query81	526	243	239	239
query82	1269	114	115	114
query83	269	143	140	140
query84	281	76	82	76
query85	1034	293	295	293
query86	420	295	292	292
query87	4446	4330	4228	4228
query88	3883	2395	2367	2367
query89	409	285	287	285
query90	1979	186	187	186
query91	182	150	148	148
query92	67	52	51	51
query93	2918	553	558	553
query94	896	297	291	291
query95	349	259	256	256
query96	641	278	293	278
query97	3336	3226	3196	3196
query98	215	202	194	194
query99	1671	1410	1423	1410
Total cold run time: 322164 ms
Total hot run time: 198286 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.98 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ca37c4cf96360adae590201e3659f21ab857d136, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.64	0.10	0.10
query5	0.52	0.53	0.52
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.50	0.49
query10	0.55	0.54	0.56
query11	0.14	0.10	0.11
query12	0.16	0.10	0.12
query13	0.62	0.60	0.59
query14	2.73	2.75	2.72
query15	0.90	0.82	0.84
query16	0.38	0.39	0.36
query17	0.97	1.01	0.97
query18	0.23	0.22	0.21
query19	1.94	1.86	2.01
query20	0.01	0.01	0.01
query21	15.36	0.58	0.57
query22	2.64	2.11	1.71
query23	16.97	0.93	0.74
query24	3.03	0.32	1.20
query25	0.34	0.21	0.19
query26	0.29	0.14	0.13
query27	0.04	0.04	0.04
query28	11.16	1.09	1.08
query29	12.61	3.26	3.25
query30	0.24	0.06	0.06
query31	2.88	0.38	0.39
query32	3.24	0.46	0.46
query33	2.99	3.01	3.04
query34	16.95	4.49	4.51
query35	4.56	4.51	4.55
query36	0.66	0.47	0.50
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.35 s
Total hot run time: 31.98 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants