Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](audit) fix sql has same sqlhash in one request #48242 #48269

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #48242

### What problem does this PR solve?

Problem Summary:

before this pr:
send multi statements in one request: sq1(e.g. select 1 from
t1);sql2(e.g. select 2 from t2);sql3(e.g. use db1)
The sqlhash of sql1, sql2 and sql3 is same.

after this pr:
the sqlhash of sql1 and sql2 and sql3 is different.
@Thearas
Copy link
Contributor

Thearas commented Feb 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 25, 2025
@Thearas
Copy link
Contributor

Thearas commented Feb 25, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40975 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 975dba39ae312bf79858313a469dbf05130e80bf, data reload: false

------ Round 1 ----------------------------------
q1	17577	7479	7345	7345
q2	2063	180	196	180
q3	10544	1089	1172	1089
q4	10588	743	709	709
q5	7768	2824	2760	2760
q6	235	150	147	147
q7	972	632	617	617
q8	9374	1931	2076	1931
q9	6582	6374	6342	6342
q10	6996	2310	2371	2310
q11	467	275	271	271
q12	416	224	214	214
q13	17782	2993	3038	2993
q14	247	211	211	211
q15	568	512	511	511
q16	655	582	582	582
q17	968	620	518	518
q18	7259	6693	6730	6693
q19	1388	1064	976	976
q20	515	204	205	204
q21	4029	3475	3364	3364
q22	1093	1016	1008	1008
Total cold run time: 108086 ms
Total hot run time: 40975 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7333	7451	7427	7427
q2	332	238	231	231
q3	2955	2931	2975	2931
q4	2111	1812	1837	1812
q5	5682	5773	5695	5695
q6	223	143	149	143
q7	2267	1813	1821	1813
q8	3370	3548	3571	3548
q9	8902	8884	8865	8865
q10	3564	3611	3584	3584
q11	621	503	505	503
q12	797	639	650	639
q13	9059	3156	3211	3156
q14	302	284	289	284
q15	577	530	518	518
q16	698	655	677	655
q17	1837	1663	1631	1631
q18	8299	7718	7757	7718
q19	1667	1558	1538	1538
q20	2109	1836	1868	1836
q21	5658	5346	5308	5308
q22	1151	1094	1062	1062
Total cold run time: 69514 ms
Total hot run time: 60897 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198928 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 975dba39ae312bf79858313a469dbf05130e80bf, data reload: false

query1	1342	929	939	929
query2	6245	2055	1963	1963
query3	10951	4378	4514	4378
query4	65887	29193	23606	23606
query5	5013	461	448	448
query6	419	188	178	178
query7	5676	316	322	316
query8	312	235	224	224
query9	9130	2730	2712	2712
query10	475	281	277	277
query11	17653	15623	16002	15623
query12	153	105	102	102
query13	1582	458	441	441
query14	11176	7307	7662	7307
query15	200	190	183	183
query16	7193	480	506	480
query17	1118	603	621	603
query18	1886	320	326	320
query19	230	173	174	173
query20	127	116	120	116
query21	206	104	106	104
query22	4645	4604	4507	4507
query23	34736	34022	34529	34022
query24	6084	2935	2975	2935
query25	536	426	436	426
query26	657	179	173	173
query27	1878	347	369	347
query28	4088	2496	2440	2440
query29	710	475	453	453
query30	247	166	162	162
query31	999	837	865	837
query32	65	59	54	54
query33	494	292	298	292
query34	893	502	540	502
query35	874	718	730	718
query36	1080	990	968	968
query37	121	69	73	69
query38	4187	3958	3935	3935
query39	1517	1495	1492	1492
query40	200	103	104	103
query41	50	48	47	47
query42	119	109	103	103
query43	526	490	498	490
query44	1204	858	862	858
query45	193	169	167	167
query46	1163	744	748	744
query47	1999	1937	1930	1930
query48	486	388	383	383
query49	753	433	421	421
query50	840	453	431	431
query51	7244	7315	7214	7214
query52	108	93	92	92
query53	272	186	190	186
query54	568	463	448	448
query55	78	86	81	81
query56	250	237	258	237
query57	1223	1075	1138	1075
query58	214	202	209	202
query59	3166	3040	2878	2878
query60	286	258	252	252
query61	114	110	110	110
query62	864	728	745	728
query63	225	189	197	189
query64	1393	679	654	654
query65	3315	3205	3205	3205
query66	725	346	302	302
query67	16127	15606	15569	15569
query68	4097	599	575	575
query69	425	278	276	276
query70	1239	1123	1124	1123
query71	358	260	262	260
query72	6402	4169	4058	4058
query73	770	348	346	346
query74	10117	9374	9108	9108
query75	3334	2658	2675	2658
query76	1956	1069	1045	1045
query77	523	292	279	279
query78	10546	9642	9649	9642
query79	1113	590	613	590
query80	851	443	437	437
query81	505	248	239	239
query82	1304	91	87	87
query83	240	147	143	143
query84	288	84	83	83
query85	870	321	307	307
query86	333	306	294	294
query87	4471	4249	4317	4249
query88	3346	2425	2386	2386
query89	416	293	299	293
query90	2055	189	192	189
query91	181	153	151	151
query92	66	51	55	51
query93	1321	555	545	545
query94	801	291	315	291
query95	356	261	261	261
query96	611	284	284	284
query97	3382	3178	3150	3150
query98	218	205	199	199
query99	1686	1429	1415	1415
Total cold run time: 318671 ms
Total hot run time: 198928 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.93 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 975dba39ae312bf79858313a469dbf05130e80bf, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.52	0.49	0.52
query6	1.14	0.72	0.74
query7	0.02	0.02	0.02
query8	0.04	0.05	0.03
query9	0.55	0.51	0.50
query10	0.56	0.54	0.54
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.59
query14	2.87	2.73	2.89
query15	0.92	0.82	0.82
query16	0.38	0.37	0.37
query17	1.04	1.03	1.03
query18	0.23	0.22	0.21
query19	1.98	1.78	1.98
query20	0.01	0.00	0.01
query21	15.35	0.57	0.59
query22	2.93	2.64	1.52
query23	16.81	0.90	0.75
query24	3.37	1.49	0.51
query25	0.27	0.10	0.08
query26	0.51	0.13	0.14
query27	0.04	0.04	0.04
query28	10.47	1.10	1.08
query29	12.62	3.24	3.23
query30	0.24	0.06	0.06
query31	2.88	0.39	0.38
query32	3.24	0.47	0.45
query33	2.95	3.08	3.00
query34	17.17	4.55	4.53
query35	4.54	4.55	4.60
query36	0.65	0.47	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.16	0.14	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.63 s
Total hot run time: 31.93 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants