Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](jvm) the jvm opt should only be set once #48335 #48342

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #48335

### What problem does this PR solve?

Introduced from #47299 
the `SetEnvIfNecessary` may be called multiple times, and in #47299,
we changed `setenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 0);` to
`setenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 1);`
so it will add `krb5 path` at the end of `LIBHDFS_OPTS` and set it every
time, so `LIBHDFS_OPTS` becomes longer and longer.

This PR fix this issue by calling `SetEnvIfNecessary` only once
@Thearas
Copy link
Contributor

Thearas commented Feb 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 26, 2025
@Thearas
Copy link
Contributor

Thearas commented Feb 26, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39841 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0bf9e496ad19629adada747087a130014cb0ec16, data reload: false

------ Round 1 ----------------------------------
q1	17583	6732	6630	6630
q2	2071	174	172	172
q3	10610	1063	1136	1063
q4	10567	782	747	747
q5	7725	2812	2795	2795
q6	223	136	137	136
q7	974	614	610	610
q8	9362	1954	2029	1954
q9	6657	6371	6371	6371
q10	6984	2241	2285	2241
q11	451	262	262	262
q12	397	213	212	212
q13	17944	2994	3131	2994
q14	242	220	206	206
q15	498	467	476	467
q16	657	600	597	597
q17	980	595	577	577
q18	7357	6745	6613	6613
q19	1395	1058	940	940
q20	488	210	200	200
q21	4017	3035	3269	3035
q22	1140	1019	1022	1019
Total cold run time: 108322 ms
Total hot run time: 39841 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6612	6609	6618	6609
q2	332	228	228	228
q3	2924	2749	2899	2749
q4	2064	1754	1763	1754
q5	5774	5757	5740	5740
q6	205	129	128	128
q7	2242	1806	1854	1806
q8	3374	3538	3509	3509
q9	8896	8874	8874	8874
q10	3538	3509	3557	3509
q11	577	515	501	501
q12	805	632	612	612
q13	9888	3260	3247	3247
q14	305	282	289	282
q15	515	463	459	459
q16	691	672	659	659
q17	1861	1641	1594	1594
q18	8271	7822	7739	7739
q19	1653	1564	1612	1564
q20	2129	1891	1871	1871
q21	5591	5268	5343	5268
q22	1178	1058	1052	1052
Total cold run time: 69425 ms
Total hot run time: 59754 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198424 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0bf9e496ad19629adada747087a130014cb0ec16, data reload: false

query1	1280	911	877	877
query2	6231	2061	2101	2061
query3	10873	4578	4534	4534
query4	61709	32886	23233	23233
query5	4628	469	440	440
query6	392	186	180	180
query7	5427	317	305	305
query8	315	227	235	227
query9	8437	2585	2594	2585
query10	446	267	265	265
query11	16212	15356	15965	15356
query12	159	103	108	103
query13	1426	436	423	423
query14	10815	6678	7589	6678
query15	207	173	185	173
query16	7038	506	489	489
query17	1157	591	592	591
query18	1885	319	331	319
query19	196	162	159	159
query20	118	115	107	107
query21	205	102	104	102
query22	4832	4497	4926	4497
query23	34686	34148	34599	34148
query24	6245	2998	2971	2971
query25	543	432	438	432
query26	661	181	186	181
query27	1812	361	369	361
query28	4167	2486	2424	2424
query29	721	470	485	470
query30	692	168	163	163
query31	1021	827	867	827
query32	71	55	58	55
query33	414	291	285	285
query34	925	497	507	497
query35	876	714	723	714
query36	1103	981	1002	981
query37	119	72	65	65
query38	4173	4081	4021	4021
query39	1557	1499	1489	1489
query40	221	111	110	110
query41	55	51	54	51
query42	121	107	104	104
query43	549	500	515	500
query44	1526	882	843	843
query45	191	181	174	174
query46	1181	742	760	742
query47	2111	2049	2105	2049
query48	506	405	402	402
query49	737	397	401	397
query50	867	440	450	440
query51	7617	7251	7212	7212
query52	102	89	89	89
query53	272	183	182	182
query54	574	476	470	470
query55	83	78	86	78
query56	257	248	246	246
query57	1293	1204	1200	1200
query58	243	221	229	221
query59	3523	3273	3170	3170
query60	298	246	254	246
query61	118	130	136	130
query62	911	686	697	686
query63	212	214	200	200
query64	4450	674	632	632
query65	3285	3247	3207	3207
query66	736	297	336	297
query67	16070	15853	15739	15739
query68	3951	582	559	559
query69	441	264	259	259
query70	1182	1105	1126	1105
query71	353	253	255	253
query72	6377	4076	4012	4012
query73	763	352	355	352
query74	10366	9256	9206	9206
query75	3367	2668	2682	2668
query76	1985	1131	1065	1065
query77	482	272	266	266
query78	10661	9715	9547	9547
query79	1759	607	609	607
query80	962	424	452	424
query81	535	238	236	236
query82	188	88	85	85
query83	167	149	143	143
query84	288	75	82	75
query85	912	296	285	285
query86	425	299	296	296
query87	4565	4291	4413	4291
query88	4379	2373	2391	2373
query89	405	289	289	289
query90	2039	187	189	187
query91	182	150	154	150
query92	64	51	51	51
query93	2167	544	547	544
query94	794	290	308	290
query95	355	258	253	253
query96	614	281	280	280
query97	3282	3245	3184	3184
query98	213	204	198	198
query99	1551	1286	1294	1286
Total cold run time: 317657 ms
Total hot run time: 198424 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.79 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0bf9e496ad19629adada747087a130014cb0ec16, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.11
query5	0.52	0.50	0.49
query6	1.13	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.54	0.54	0.57
query11	0.14	0.10	0.10
query12	0.16	0.12	0.11
query13	0.61	0.60	0.60
query14	2.73	2.76	2.86
query15	0.90	0.82	0.83
query16	0.38	0.37	0.37
query17	1.00	1.02	0.98
query18	0.23	0.22	0.22
query19	1.83	1.80	2.00
query20	0.01	0.01	0.01
query21	15.35	0.60	0.58
query22	2.40	1.97	1.74
query23	16.98	0.99	0.85
query24	3.07	1.77	0.66
query25	0.21	0.09	0.16
query26	0.41	0.15	0.13
query27	0.04	0.05	0.06
query28	10.17	0.47	0.49
query29	12.59	3.27	3.21
query30	0.24	0.06	0.06
query31	2.88	0.40	0.37
query32	3.25	0.46	0.45
query33	2.96	2.98	3.03
query34	16.96	4.54	4.52
query35	4.62	4.55	4.62
query36	0.67	0.49	0.50
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 106.05 s
Total hot run time: 31.79 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants