Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](client) Do not log in thrift exception when ADDRESS_SANITIZER is defined #48347 #48362

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #48347

…s defined (#48347)

Logging in thrift exception will cause BE crash when ADDRESS_SANITIZER
is defined. But PR #36808 uses the opposite condition, causing logging
to be turned on only in ADDRESS_SANITIZER enabled.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 26, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39946 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6c8b50ccaa6abb477f2e7e033c18a537bc6375ca, data reload: false

------ Round 1 ----------------------------------
q1	17584	6713	6592	6592
q2	2057	177	167	167
q3	10552	1075	1157	1075
q4	10453	758	784	758
q5	7732	2857	2821	2821
q6	220	132	130	130
q7	969	606	587	587
q8	9336	1941	2075	1941
q9	6658	6427	6423	6423
q10	7031	2252	2277	2252
q11	474	264	257	257
q12	402	216	212	212
q13	17778	2964	2986	2964
q14	225	201	210	201
q15	505	478	468	468
q16	672	594	576	576
q17	968	535	621	535
q18	7200	6594	6632	6594
q19	1393	1040	1080	1040
q20	490	217	202	202
q21	3978	3363	3148	3148
q22	1106	1003	1004	1003
Total cold run time: 107783 ms
Total hot run time: 39946 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6679	6664	6719	6664
q2	336	246	248	246
q3	2967	2833	2986	2833
q4	2100	1875	1839	1839
q5	5906	5863	5890	5863
q6	210	136	132	132
q7	2301	1844	1905	1844
q8	3440	3644	3574	3574
q9	9116	8934	8989	8934
q10	3560	3538	3579	3538
q11	613	481	493	481
q12	848	593	606	593
q13	12057	3311	3335	3311
q14	333	298	290	290
q15	518	480	466	466
q16	703	652	666	652
q17	1885	1642	1638	1638
q18	8704	8102	7722	7722
q19	3632	1660	1612	1612
q20	2128	1906	1814	1814
q21	5490	5377	5460	5377
q22	1110	1052	1037	1037
Total cold run time: 74636 ms
Total hot run time: 60460 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197868 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6c8b50ccaa6abb477f2e7e033c18a537bc6375ca, data reload: false

query1	1258	886	924	886
query2	6263	2087	2132	2087
query3	10961	4451	4485	4451
query4	33114	23566	23482	23482
query5	4293	477	447	447
query6	279	176	183	176
query7	3985	311	325	311
query8	291	224	219	219
query9	9493	2576	2578	2576
query10	475	256	257	256
query11	17869	15272	15064	15064
query12	151	108	105	105
query13	1542	424	417	417
query14	9522	7654	7197	7197
query15	248	180	191	180
query16	8108	528	503	503
query17	1713	595	601	595
query18	2151	329	323	323
query19	361	164	170	164
query20	126	117	121	117
query21	204	107	111	107
query22	4716	4361	4758	4361
query23	34974	34405	34114	34114
query24	11854	2962	2946	2946
query25	742	435	427	427
query26	1793	173	175	173
query27	2635	347	339	339
query28	8173	2455	2396	2396
query29	1066	488	438	438
query30	269	164	161	161
query31	1046	773	831	773
query32	93	57	64	57
query33	775	284	289	284
query34	1051	530	548	530
query35	885	750	745	745
query36	1117	970	963	963
query37	196	70	72	70
query38	4259	4143	4076	4076
query39	1539	1474	1472	1472
query40	254	107	99	99
query41	48	49	46	46
query42	124	99	96	96
query43	549	499	488	488
query44	1276	840	820	820
query45	183	170	171	170
query46	1169	762	698	698
query47	1996	1895	1885	1885
query48	469	388	389	388
query49	1046	413	383	383
query50	846	434	446	434
query51	7274	7251	7304	7251
query52	103	95	88	88
query53	273	188	186	186
query54	1207	475	468	468
query55	78	76	80	76
query56	264	252	258	252
query57	1299	1141	1161	1141
query58	231	228	211	211
query59	3315	3349	3104	3104
query60	289	265	257	257
query61	138	148	124	124
query62	875	693	707	693
query63	230	199	199	199
query64	4915	679	630	630
query65	3251	3191	3228	3191
query66	1315	294	294	294
query67	16116	15557	15737	15557
query68	4893	575	551	551
query69	415	263	272	263
query70	1175	1063	1134	1063
query71	325	256	266	256
query72	6159	3968	3961	3961
query73	771	353	353	353
query74	10300	9285	8936	8936
query75	3415	2660	2648	2648
query76	2602	1122	1128	1122
query77	402	274	268	268
query78	10636	9685	9642	9642
query79	1247	613	592	592
query80	997	437	433	433
query81	564	236	241	236
query82	1073	90	87	87
query83	242	148	139	139
query84	231	81	81	81
query85	1308	368	374	368
query86	376	302	305	302
query87	4425	4370	4312	4312
query88	3728	2407	2374	2374
query89	412	294	298	294
query90	1980	187	188	187
query91	192	152	151	151
query92	58	51	50	50
query93	1306	535	540	535
query94	936	282	300	282
query95	374	266	257	257
query96	616	286	280	280
query97	3341	3148	3198	3148
query98	208	206	192	192
query99	1486	1288	1289	1288
Total cold run time: 304916 ms
Total hot run time: 197868 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6c8b50ccaa6abb477f2e7e033c18a537bc6375ca, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.02
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.50	0.51	0.51
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.03	0.03	0.04
query9	0.57	0.50	0.50
query10	0.55	0.55	0.56
query11	0.14	0.10	0.09
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.70	2.74	2.86
query15	0.87	0.81	0.82
query16	0.38	0.39	0.38
query17	1.07	1.07	1.06
query18	0.23	0.22	0.22
query19	1.93	1.78	1.98
query20	0.01	0.01	0.01
query21	15.35	0.60	0.56
query22	2.79	1.82	1.62
query23	17.03	0.90	0.89
query24	2.94	1.27	1.06
query25	0.21	0.20	0.10
query26	0.41	0.13	0.14
query27	0.03	0.04	0.04
query28	10.33	0.53	0.44
query29	12.57	3.31	3.29
query30	0.25	0.06	0.06
query31	2.89	0.38	0.37
query32	3.24	0.45	0.46
query33	2.99	3.01	3.02
query34	17.23	4.51	4.49
query35	4.59	4.59	4.56
query36	0.68	0.48	0.51
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.13	0.14
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.85 s
Total hot run time: 32.2 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants