Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](binlog) Wrong judgment of anyEnable for add binlog #48919

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Mar 11, 2025

What problem does this PR solve?

Issue Number: close #xxx

if (!(table instanceof OlapTable)) {
    LOG.warn("table is not olap table. db: {}, table id: {}", db.getFullName(), tableId);
    return null;
}

View don't have enable binlog config cache, so binlog is not enabled by default when a view is created.

Related PR: #40680

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

run buildall

@w41ter w41ter requested a review from Yulei-Yang March 11, 2025 07:59
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 11, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32533 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b2fcb31261266c30e2faca0f6467727c21da996c, data reload: false

------ Round 1 ----------------------------------
q1	17614	5256	5109	5109
q2	2055	291	164	164
q3	10582	1364	732	732
q4	10312	1025	536	536
q5	8903	2386	2393	2386
q6	218	162	132	132
q7	902	742	631	631
q8	9309	1320	1119	1119
q9	5602	4681	4922	4681
q10	6808	2317	1891	1891
q11	471	292	263	263
q12	352	360	227	227
q13	17789	3680	3109	3109
q14	243	224	216	216
q15	534	480	496	480
q16	649	636	574	574
q17	582	873	340	340
q18	6891	6345	6254	6254
q19	1268	949	560	560
q20	335	344	195	195
q21	2913	2176	1954	1954
q22	1040	990	980	980
Total cold run time: 105372 ms
Total hot run time: 32533 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5209	5237	5112	5112
q2	245	324	230	230
q3	2155	2705	2310	2310
q4	1489	1827	1367	1367
q5	4255	4132	4152	4132
q6	209	166	124	124
q7	1982	1972	1789	1789
q8	2647	2680	2592	2592
q9	7104	7196	7056	7056
q10	2960	3200	2749	2749
q11	615	498	491	491
q12	677	792	627	627
q13	3564	3883	3259	3259
q14	270	290	281	281
q15	540	487	471	471
q16	666	694	648	648
q17	1162	1588	1331	1331
q18	7706	7569	7393	7393
q19	821	826	882	826
q20	1993	2017	1954	1954
q21	5533	4966	4816	4816
q22	1049	1003	993	993
Total cold run time: 52851 ms
Total hot run time: 50551 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185033 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b2fcb31261266c30e2faca0f6467727c21da996c, data reload: false

query1	994	401	366	366
query2	6526	1926	1864	1864
query3	6794	228	212	212
query4	26643	23561	23045	23045
query5	4371	638	487	487
query6	318	204	199	199
query7	4600	503	300	300
query8	301	237	238	237
query9	8607	2657	2638	2638
query10	482	322	262	262
query11	15418	15260	14939	14939
query12	160	111	106	106
query13	1664	526	405	405
query14	9601	6475	6217	6217
query15	210	189	169	169
query16	7505	642	489	489
query17	1226	720	585	585
query18	2005	412	322	322
query19	192	195	168	168
query20	122	119	125	119
query21	216	126	105	105
query22	4275	4165	3957	3957
query23	34061	33155	33033	33033
query24	7747	2361	2376	2361
query25	532	474	387	387
query26	1254	271	154	154
query27	2372	482	337	337
query28	4163	2447	2442	2442
query29	725	574	420	420
query30	279	222	189	189
query31	934	895	764	764
query32	75	62	67	62
query33	568	351	304	304
query34	783	826	500	500
query35	817	823	761	761
query36	938	993	910	910
query37	112	99	78	78
query38	4203	4177	4145	4145
query39	1415	1386	1400	1386
query40	217	118	102	102
query41	55	50	50	50
query42	123	104	101	101
query43	508	503	460	460
query44	1290	784	774	774
query45	172	171	163	163
query46	830	1033	621	621
query47	1761	1782	1694	1694
query48	370	408	304	304
query49	787	509	405	405
query50	682	718	405	405
query51	4216	4185	4084	4084
query52	116	107	101	101
query53	225	248	185	185
query54	492	495	419	419
query55	83	77	83	77
query56	272	269	259	259
query57	1155	1128	1086	1086
query58	245	232	242	232
query59	2644	2561	2603	2561
query60	289	294	258	258
query61	123	124	123	123
query62	827	732	646	646
query63	226	187	187	187
query64	4262	1004	665	665
query65	4477	4372	4362	4362
query66	1106	415	315	315
query67	15682	15369	15076	15076
query68	8523	878	506	506
query69	465	322	266	266
query70	1212	1116	1076	1076
query71	468	290	265	265
query72	5513	3575	3803	3575
query73	783	720	348	348
query74	9175	8905	9069	8905
query75	3911	3149	2712	2712
query76	3702	1171	746	746
query77	779	368	344	344
query78	9905	10166	9336	9336
query79	2791	826	590	590
query80	683	522	450	450
query81	480	262	227	227
query82	700	130	96	96
query83	203	180	161	161
query84	286	100	76	76
query85	789	354	315	315
query86	381	288	292	288
query87	4452	4590	4319	4319
query88	3542	2327	2324	2324
query89	395	317	295	295
query90	1902	212	225	212
query91	137	146	112	112
query92	73	59	56	56
query93	1743	1064	594	594
query94	650	420	365	365
query95	353	274	262	262
query96	475	578	277	277
query97	3401	3410	3331	3331
query98	233	207	208	207
query99	1463	1383	1258	1258
Total cold run time: 276011 ms
Total hot run time: 185033 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.84 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b2fcb31261266c30e2faca0f6467727c21da996c, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.23	0.07	0.06
query4	1.63	0.11	0.10
query5	0.56	0.58	0.55
query6	1.20	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.58	0.53	0.52
query10	0.59	0.60	0.58
query11	0.16	0.10	0.11
query12	0.15	0.10	0.11
query13	0.62	0.61	0.60
query14	2.68	2.81	2.70
query15	0.93	0.86	0.84
query16	0.38	0.39	0.38
query17	1.03	1.00	1.00
query18	0.21	0.20	0.20
query19	1.92	1.83	1.94
query20	0.02	0.01	0.02
query21	15.36	0.89	0.55
query22	0.75	1.25	0.65
query23	14.81	1.38	0.62
query24	7.74	1.72	0.88
query25	0.54	0.27	0.14
query26	0.55	0.16	0.12
query27	0.06	0.04	0.04
query28	9.66	0.75	0.41
query29	12.54	4.00	3.37
query30	0.24	0.09	0.06
query31	2.83	0.60	0.38
query32	3.22	0.54	0.47
query33	2.98	3.02	2.98
query34	15.63	5.10	4.48
query35	4.47	4.48	4.51
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.57 s
Total hot run time: 30.84 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w41ter w41ter merged commit bf50dd5 into apache:master Mar 12, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants