Repository navigation
fix: Properly compute virtual column chains post-join. - #20538
Merged
Merged
Conversation
Previously, when separating virtual columns into pre- and post-join sets, we would only look one layer deep. This patch changes the logic to look through multiple layers, so chains of virtual columns that depend on post-join inputs are properly moved post-join in their entirety.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| new TableDataSource(CalciteTests.DATASOURCE1), | ||
| new LookupDataSource("lookyloo"), | ||
| "j0.", | ||
| equalsCondition(makeColumnExpression("dim2"), makeColumnExpression("j0.k")), |
| new TableDataSource(CalciteTests.DATASOURCE1), | ||
| new LookupDataSource("lookyloo"), | ||
| "j0.", | ||
| equalsCondition(makeColumnExpression("dim2"), makeColumnExpression("j0.k")), |
clintropolis
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when separating virtual columns into pre- and post-join sets, we would only look one layer deep. This patch changes the logic to look through multiple layers, so chains of virtual columns that depend on post-join inputs are properly moved post-join in their entirety.