Skip to content

fix(web-console): avoid schema discovery for Druid reingestion - #20553

Draft
sakshichitnis27 wants to merge 1 commit into
apache:masterfrom
sakshichitnis27:fix-19036-complex-metric-sampling
Draft

sakshichitnis27 wants to merge 1 commit into
apache:masterfrom
sakshichitnis27:fix-19036-complex-metric-sampling

Conversation

@sakshichitnis27

Copy link
Copy Markdown
Contributor

Fixes #19036.

Description

The classic batch loader currently enables schema discovery while sampling Druid input sources. Complex metric values returned during reingestion are then treated as dimensions, causing the sampler to fail with Unhandled type: COMPLEX.

This PR disables schema discovery only for Druid reingestion samples, restoring the behavior from before the Delta sampling change. Other fixed-format sources, including Delta, continue to use schema discovery.

Regression tests cover both request shapes.

Release note

Fixed classic batch loader sampling when reingesting from Druid datasources that contain complex metrics.

Testing

  • npx jest --config jest.config.js src/utils/sampler.spec.ts --runInBand
  • npx jest --config jest.config.js --testPathIgnorePatterns=e2e-tests --runInBand (167 suites, 852 tests)
  • npm run typecheck
  • npm run eslint
  • npm run sasslint
  • npm run prettify-check

Key changed/added classes in this PR
  • sampleForConnect

This PR has:

  • been self-reviewed.
  • a release note entry in the PR description.
  • added unit tests to cover the changed code paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Classic Batch Data Loader fails when loading a Druid Datasource with quantilesDoublesSketch

1 participant