Skip to content

feat: mark default superuser identities in AuthenticationResult context - #20616

Open
cecemei wants to merge 1 commit into
apache:masterfrom
cecemei:superuser
Open

cecemei wants to merge 1 commit into
apache:masterfrom
cecemei:superuser

Conversation

@cecemei

@cecemei cecemei commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a superuser context key to basic-security extension's default superuser identities.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@apache apache deleted a comment from kyhtsang Oct 16, 2026

@gianm gianm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new key doesn't seem to serve a purpose, since as far as I can tell it isn't read by anything. It also seems orthogonal to the permission system in general, which is potentially confusing.

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No actionable issues found. The marker is applied across HTTP and JDBC basic authentication, escalated authentication results, and default-user initialization without changing existing authorization behavior. Reviewed 5 of 5 changed files, including all production changes, the added unit tests, and relevant AuthenticationResult consumers, validators, role providers, and escalator call sites. Static review only; no build or test commands were run.


This is an automated review by Codex GPT-5.6-Luna(max)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants