Skip to content

fix(line): fix line may cross in time axis when animation is enabled#18960

Merged
Ovilia merged 1 commit into
masterfrom
fix/line-animation
Nov 30, 2023
Merged

fix(line): fix line may cross in time axis when animation is enabled#18960
Ovilia merged 1 commit into
masterfrom
fix/line-animation

Conversation

@plainheart

@plainheart plainheart commented Aug 4, 2023

Copy link
Copy Markdown
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix a bug brought by #18032, it may result in abnormal line animation.

Fixed issues

Reproduction Link

Before

After

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot

echarts-bot Bot commented Aug 4, 2023

Copy link
Copy Markdown

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.5.0 milestone Aug 4, 2023
@plainheart plainheart requested a review from pissang August 4, 2023 05:55
@github-actions

github-actions Bot commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18960@7d02d5c

@plainheart plainheart changed the title fix(line): fix line may cross when animation is enabled fix(line): fix line may cross in time axis when animation is enabled Aug 4, 2023
@plainheart plainheart requested review from pissang and removed request for pissang October 6, 2023 07:09
@plainheart plainheart requested review from Ovilia and removed request for pissang November 17, 2023 03:46
@Ovilia Ovilia merged commit 80525ed into master Nov 30, 2023
@echarts-bot

echarts-bot Bot commented Nov 30, 2023

Copy link
Copy Markdown

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants