Skip to content

[BP-3.6][FLINK-39573][docs] Fix Build documentation CI for release-3.6 - #4592

Merged
lvyanquan merged 2 commits into
apache:release-3.6from
lvyanquan:hotfix-doc
Oct 23, 2026
Merged

lvyanquan merged 2 commits into
apache:release-3.6from
lvyanquan:hotfix-doc

Conversation

@lvyanquan

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request?

The scheduled Build documentation workflow runs from master but checks out each branch in its matrix. Since FLINK-39573 (#4385), the upload steps use the local action ./.github/actions/rsync-deployments, which only exists on master and release-3.7. As a result, the Check and build doc (release-3.6) job fails every day with:

Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '.github/actions/rsync-deployments'.

In addition, tcort/github-action-markdown-link-check is no longer allowed by the Apache Infra actions policy, which causes startup_failure for docs PRs. It has already been removed from master in #4589; this PR removes it from release-3.6 as well.

Brief change log


Verifying this change

This change is a trivial CI fix without any test coverage. It can be verified by the Check and build doc (release-3.6) job of the next scheduled Build documentation run.

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Qoder

yuanoOo and others added 2 commits October 23, 2026 11:34
…ailure by replacing third-party rsync action (apache#4385)

The Build documentation workflow has been failing with startup_failure
since April 18, 2026 because burnett01/rsync-deployments is not allowed
by the Apache Infra actions policy.

Replace the third-party action with a local composite action that uses
native rsync and ssh-agent, following the same approach used in
FLINK-38448 for flink-kubernetes-operator. This eliminates the
dependency on third-party actions entirely and avoids future breakage
from allowed list changes or version expirations.

Note: After merging, this action needs to be backported to release-3.5
and release-3.6 branches as well, since the workflow checks out those
branches and requires the local action to be present.

(cherry picked from commit 24ab548)
…orkflow

Co-Authored-By: Qoder <noreply@qoder.com>
AI-Contributed/Feature: 9/9
AI-Contributed/UT: 0/0
@yuxiqian

yuxiqian commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

LGTM.

I suggest we may add the workflow_dispatch into the trigger, so we can trigger docs building manually. WDYT?

@lvyanquan

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @yuxiqian! workflow_dispatch is already in the trigger list on release-3.6 (as well as master and release-3.7), so the docs build can be triggered manually from the Actions page.

Note that it should be dispatched from master, which builds master, release-3.7 and release-3.6 in one run. The build-documentation matrix on release-3.6 is outdated (master / release-3.5 / release-3.4), so dispatching from the release-3.6 branch is not recommended.

@github-actions github-actions Bot added the build label Oct 23, 2026
@lvyanquan
lvyanquan merged commit 7b9bfd9 into apache:release-3.6 Oct 23, 2026
17 of 20 checks passed
@yuxiqian

Copy link
Copy Markdown
Member

Could you please remove the dead-links check in release-3.7 branch, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants