Skip to content

[FLINK-39816] Ship parsson into es8 uber jar - #156

Merged
reswqa merged 5 commits into
apache:mainfrom
reswqa:fix-parsson
Jun 26, 2026
Merged

[FLINK-39816] Ship parsson into es8 uber jar#156
reswqa merged 5 commits into
apache:mainfrom
reswqa:fix-parsson

Conversation

@reswqa

@reswqa reswqa commented Jun 2, 2026

Copy link
Copy Markdown
Member

We should ship parsson into uber jar, otherwise es client can not parse reponse(Elasticsearch-Java client relies on it for JSON parsing).

@reswqa

reswqa commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

CI failed as license checker not happy

07:46:12,032 [org.apache.flink.tools.ci.licensecheck.LicenseChecker.main()] ERROR org.apache.flink.tools.ci.licensecheck.JarFileChecker        [] - File '/org/apache/flink/elasticsearch8/shaded/org/eclipse/parsson/messages.properties' in jar '/tmp/flink-validation-deployment/org/apache/flink/flink-sql-connector-elasticsearch8/4.1-SNAPSHOT/flink-sql-connector-elasticsearch8-4.1-20260602.072511-1.jar' contains match with forbidden regex 'gnu ?\R?[\s/#]*general ?\R?[\s/#]*public ?\R?[\s/#]*license'.

@davidradl

Copy link
Copy Markdown

@reswqa You could consider using the connector parent version 2 has has the standard RAT checker in it.

@reswqa

reswqa commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

@davidradl Yes, I have already created [FLINK-39809] Update flink-connector-parent to 2.0 for ElasticSearch connector for the updating.

But as for this PR, the failed checker comes from LicenseChecker in flink-ci-tools, more specifically, it is org.apache.flink.tools.ci.licensecheck.JarFileChecker in flink main repo. I don't understand why upgrading flink-connector-parent would solve the problem. Did I miss something?

@davidradl

Copy link
Copy Markdown

JarFileChecker

No you did not miss anything, just an observation that maybe the RAT checker would have surfaced this issue at build time.

Comment thread .github/workflows/push_pr.yml Outdated
strategy:
matrix:
flink: [ 2.2.1 ]
flink: [ 2.3-SNAPSHOT ]

@reswqa reswqa Jun 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fix the upstream in release-2.2 and master branch. So temporarily change this to snapshot binary version.

GenericRowData.of(
1L,
12345,
12000,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to incompatible changes in the upstream([FLINK-17224][table] Support precision of TIME type)

@reswqa
reswqa merged commit 6e62c67 into apache:main Jun 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants