Skip to content

Conversation

@ClownfishYang
Copy link

What is the purpose of the change

Translate "Common Rules" page into Chinese.

Brief change log

I modified the "contributing/code-style-and-quality-common.zh.md" file .

Verifying this change

I have verified the changes by starting the build script in preview mode.

@wuchong wuchong changed the title Translate "Common Rules" page into Chinese [FLINK-13680] Translate "Common Rules" page into Chinese Sep 23, 2019
@klion26
Copy link
Member

klion26 commented Nov 13, 2020

@ClownfishYang could you please clean the git history by getting rid of the git merge commit(you can use git rebase instead), after that I can have a look. thanks.

@ClownfishYang
Copy link
Author

@klion26 I think it would be easier for me to submit a new request.#394

@klion26
Copy link
Member

klion26 commented Nov 17, 2020

@ClownfishYang as you've created a new pr, could you please close this one.

@ClownfishYang
Copy link
Author

OK,My closed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants