Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37207][runtime] Don't clear distributed cache in StreamExecutionEnvironment.configure #26062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dianfu
Copy link
Contributor

@dianfu dianfu commented Jan 23, 2025

What is the purpose of the change

This pull request fixes the issue that the distributed cache was cleared in StreamExecutionEnvironment.configure. It has side effect that distributed caches set before will be cleared. It may happen in the case that a job mixes use of the DataStream API and Java Table API and it has set distributed cache in the DataStream API. I encountered this issue in a PyFlink job which mixes use of DataStream API and Table API.

Brief change log

  • Remove the cacheFile.clear in StreamExecutionEnvironment.configure

Verifying this change

This change is a trivial rework without any test coverage and verified locallly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 23, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test for this please

@davidradl
Copy link
Contributor

Reviewed by Chi on 23/01/2025 Go back to the submitter with review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants