[FLINK-38460][tests] Improve test coverage for SinkUpsertMaterializer #27068
+960
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkhachatryan
changed the title
twalthr
reviewed
Sep 30, 2025
| import org.apache.flink.runtime.state.hashmap.HashMapStateBackend; | ||
|
|
||
| /** StateBackend to test SinkUpsertMaterializer with. */ | ||
| public enum SumStateBackend { |
There was a problem hiding this comment.
The term "sum" is very confusing in a SQL context where SUM, COUNT are core aggregation functions. Please use at least UpsertMaterializerStateBackend or so instead.
There was a problem hiding this comment.
Thanks, renamed to SinkUpsertMaterializerStateBackend
rkhachatryan
force-pushed
the
f38460
branch
from
d542ebb to
c7e2cb7
Compare
rkhachatryan
force-pushed
the
f38460
branch
from
c7e2cb7 to
bbc876d
Compare
|
@twalthr can you take another look please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends test coverage for
SinkUpsertMaterializer.The tests will be parameterized in #27070 to test the current and the new version of it.