Skip to content

Conversation

@davidradl
Copy link
Contributor

What is the purpose of the change

The is a false positive being flagged as an error in a test python file. This change ignores the false positive.

Brief change log

add comment to ignore the check for one line

Verifying this change

CI has not error.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 4, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@rionmonster
Copy link
Contributor

@davidradl

This looks good to me -- my only nit/question would be if we needed the separate line for the comment as it could probably be inlined as I definitely think that denoting what the F401 codes explicitly does provides clarity:

import pytz  # noqa: F401  # ignore imported but unused

@davidradl davidradl marked this pull request as ready for review November 4, 2025 15:05
@dianfu
Copy link
Contributor

dianfu commented Nov 4, 2025

@davidradl Oh, as I commented on the JIRA page (https://issues.apache.org/jira/browse/FLINK-38594) , it seems that we are addressing an issue of a Pull Request: #27140. This issue should not exist in the upstream code...

@davidradl
Copy link
Contributor Author

@dianfu ok thanks for letting me know - I will close this out then.

@davidradl davidradl closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants