[hotfix][docs] Add code review guidelines to AGENTS.md - #28861
Merged
rkhachatryan merged 1 commit intoAug 4, 2026
Conversation
Collaborator
github-actions
Bot
added
the
community-reviewed
rkhachatryan
force-pushed
the
hotfix-agents-review-suggestions
branch
from
August 3, 2026 09:10
e505542 to
7338eab
Compare
Izeren
approved these changes
Aug 3, 2026
Izeren
left a comment
Izeren
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the change, @rkhachatryan
|
|
||
| - Look for opportunities to simplify the code, scoped to the diff itself (not pre-existing code outside the change). | ||
| - Flag comments that are obvious (restate what the code already says) or overly verbose. | ||
| - In test code, look for potential flakiness — e.g. `Thread.sleep` used outside a retry/poll loop, or similar timing-dependent, non-deterministic patterns. |
Contributor
There was a problem hiding this comment.
We could add something about suggestion to use clock injection for test determinism. This was suggestions from reviewer would be more helpful
Contributor
Author
There was a problem hiding this comment.
Good idea!
Update the PR, also added a mention about waiting on a condition in a loop.
github-actions
Bot
added
the
community-reviewed-LGTM
rkhachatryan
force-pushed
the
hotfix-agents-review-suggestions
branch
from
August 3, 2026 21:41
7338eab to
91fbece
Compare
rkhachatryan
marked this pull request as ready for review
August 3, 2026 21:43
Izeren
approved these changes
Aug 4, 2026
Contributor
Author
|
Thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.