[FLINK-40289][docs] Clarify watermark requirements in Window Top-N examples - #28874
Open
ipsyer wants to merge 1 commit into
Open
[FLINK-40289][docs] Clarify watermark requirements in Window Top-N examples#28874ipsyer wants to merge 1 commit into
ipsyer wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The Window Top-N examples display final results for two tumbling windows, but the example input does not advance the watermark far enough to close the second window in unbounded streaming mode.
With the documented watermark strategy, the maximum event timestamp
08:17produces a watermark of approximately08:16:59. Therefore, the[08:10, 08:20)window remains open, and its final Window Top-N result is not emitted.This change clarifies the execution conditions required to reproduce the displayed results.
JIRA: https://issues.apache.org/jira/browse/FLINK-40289
Brief change log
release-1.20will be submitted separately.Verifying this change
This is a documentation-only change. No tests were added.
The watermark behavior was manually verified using the documented input:
2020-04-15 08:17:00.000.2020-04-15 08:16:59.000.[08:00, 08:10)window closes.[08:10, 08:20)window remains open in unbounded streaming mode unless subsequent records advance the watermark past its end.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex