Repository navigation
Conversation
… mode (apache#29908) * [FLINK-41446][table-planner] Ignore the EARLY_FIRE join hint in batch mode EARLY_FIRE is a streaming interval-join hint, but it is registered as a JoinStrategy, so the batch join rules passed it to checkJoinStrategyValid. That method has no case for it and threw "Unknown join strategy : EARLY_FIRE" for every batch query with the hint, inner joins included. Skip the hint there, as is already done for LOOKUP, so the batch planner chooses the join as if no hint were given. Also stop containsJoinStrategyHint from counting it: a join marked as hinted is never turned into an adaptive join, so the ignored hint would otherwise still change the batch plan under the default configuration. * [FLINK-41446][docs] Document the query-block scope of EARLY_FIRE and chained interval joins
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Backport of #29908 to release-2.4.
EARLY_FIREis a streaming interval-join hint. With this change, batch mode ignores it, as the docs describe, so a batch query with the hint plans exactly as it would without it and keeps adaptive broadcast join. The docs also describe the query-block scope of the hint and how an early-fire join combines with a downstream interval join. Having this in 2.4.0 lets users share one query between streaming and batch jobs from the first release with the hint.Brief change log
Verifying this change
This change added tests:
plan/hints/batch/EarlyFireJoinHintTest. It, the streamingEarlyFireJoinHintTest, the other batch join hint tests andAdaptiveJoinTestpass on this branch.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code 2.1.329 (Claude Opus 5.5)