[TASK-278] Add getters in CPP Datum #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@luoyuxia PTAL 🙏 |
luoyuxia
reviewed
Feb 8, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@fresh-borzoni Thanks for the pr.
Maybe we can avoid expose datum to users, we can have getter methods in GenericRow? And make all field in Datum be private?
fresh-borzoni
force-pushed
the
datum-getter-methods
branch
from
27d8fe5 to
bb5cd4f
Compare
Contributor
Author
|
@luoyuxia PTAL 🙏 |
fresh-borzoni
force-pushed
the
datum-getter-methods
branch
from
f963519 to
8886ecb
Compare
luoyuxia
approved these changes
Feb 8, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@fresh-borzoni Thanks for the pr.LGTM!
cc @zhaohaidao The cpp api to access field has changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #278
Added additional getters to decouple