Skip to content

YARN-11839. [RM HA] - In corner case, RM stay in ACTIVE with RMStateStore in FENCED state #7999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

YARN-11839. [RM HA] - In corner case, RM stay in ACTIVE with RMStateStore in FENCED state #7999

wants to merge 1 commit into from

Conversation

@vinayakumarb
Copy link
Contributor

  • Adds recheck of current state before invoking transitionToStandBy() in a new thread.
  • This re-check avoids setting of StandByTransitionRunnable#hasAlreadyRun = true when the state is already StandBy.
  • This fix, allows proper transitionToStandby() when RMStateStore reaches FENCED state.

cnauroth
cnauroth approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending pre-commits. Thank you @vinayakumarb !

ayushtkn
ayushtkn approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slfan1989
Copy link
Contributor

@vinayakumarb Thanks for the contribution! We can re-trigger the build. The crash issue in the YARN ResourceManager JUnit test has been fixed.

@cnauroth
Copy link
Contributor

I retriggered the build:

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7999/2/

@cnauroth
Copy link
Contributor

Trying again:

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7999/3/

@cnauroth
Copy link
Contributor

I don't know why, but I can't get my manually triggered CI runs to post results back to this PR. It looks clean enough to commit though, so I'm planning to commit to trunk and branch-3.4 later today.

@slfan1989
Copy link
Contributor

I don't know why, but I can't get my manually triggered CI runs to post results back to this PR. It looks clean enough to commit though, so I'm planning to commit to trunk and branch-3.4 later today.

@cnauroth LGTM. This PR is fine and can be merged.

@cnauroth cnauroth closed this in 7696764 Oct 31, 2025
cnauroth pushed a commit that referenced this pull request Oct 31, 2025
@vinayakumarb @cnauroth
YARN-11839. [RM HA] - In corner case, RM stay in ACTIVE with RMStateS…
f305840 
…tore in FENCED state

Closes #7999

Signed-off-by: Shilun Fan <[email protected]>
Signed-off-by: Chris Nauroth <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
cnauroth pushed a commit that referenced this pull request Oct 31, 2025
@vinayakumarb @cnauroth
YARN-11839. [RM HA] - In corner case, RM stay in ACTIVE with RMStateS…
b4b6a00 
…tore in FENCED state

Closes #7999

Signed-off-by: Shilun Fan <[email protected]>
Signed-off-by: Chris Nauroth <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
@cnauroth
Copy link
Contributor

I committed this to trunk, branch-3.4 and branch-3.3. @vinayakumarb , thank you for the patch. @slfan1989 and @ayushtkn , thank you for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnauroth cnauroth cnauroth approved these changes

@ayushtkn ayushtkn ayushtkn approved these changes

@slfan1989 slfan1989 slfan1989 approved these changes

Assignees

No one assigned

Labels

trunk YARN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vinayakumarb @slfan1989 @cnauroth @ayushtkn