-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19709. [JDK17] Add debian:12 and debian:13 as a build platform with JDK-17 as default #8001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
… with JDK-17 as default This commit introduces support for Debian 12 (Bookworm) and Debian 13 (Trixie) as build platforms, following the approach established for Ubuntu 24. Key changes include: - Creation of `Dockerfile_debian_12` and `Dockerfile_debian_13` based on `Dockerfile_ubuntu_24`, with appropriate base images and package resolver arguments. - Updates to `dev-support/docker/pkg-resolver/packages.json` to include package definitions for `debian:12` and `debian:13`. - Addition of `debian:12` and `debian:13` to `dev-support/docker/pkg-resolver/platforms.json`. - Modification of `BUILDING.txt` to list `debian_12` and `debian_13` as supported OS platforms.
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RUN echo 'APT::Install-Suggests "0";' >> /etc/apt/apt.conf.d/10disableextras
This is there in only in 12, if possible we should sync it with 13 as well, if relevant. Feel free to commit once you do it
Previously, there were concerns about having many versions of Linux dist Dockerfiles, how about upgrading Debian 10 to 13 directly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thanks @vinayakumarb !
@vinayakumarb Thank you very much for your contribution. However, I still have some concerns. Expanding support to many operating systems could be a rather heavy undertaking, since it requires us to pay closer attention to their EOL and version lifecycles. I'm wondering if it might be more sustainable to maintain a smaller subset of supported systems instead. If users have other requirements, they could always try customizing the build themselves. |
This commit introduces support for Debian 12 (Bookworm) and Debian 13 (Trixie) as build platforms, following the approach established for Ubuntu 24.
Key changes include:
Dockerfile_debian_12
andDockerfile_debian_13
based onDockerfile_ubuntu_24
, with appropriate base images and package resolver arguments.dev-support/docker/pkg-resolver/packages.json
to include package definitions fordebian:12
anddebian:13
.debian:12
anddebian:13
todev-support/docker/pkg-resolver/platforms.json
.BUILDING.txt
to listdebian_12
anddebian_13
as supported OS platforms.