HADOOP-10579. Add match expressions to find command#8259
HADOOP-10579. Add match expressions to find command#8259LamiumAmplexicaule wants to merge 22 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
aajisaka
left a comment
There was a problem hiding this comment.
Thank you @LamiumAmplexicaule for your work. Several comments:
- Would you add a test case to make sure multiple options are handled correctly? For example:
-mtime 10 -regex *.parquet - Would you document the new expressions in FileSystemShell.md?
- Would you fix the checkstyle issues and trailing whitespaces warned by the CI?
aajisaka
left a comment
There was a problem hiding this comment.
Here are the review comments for the tests:
|
Thank you @aajisaka for your review.
I think it’s
I documented it in this commit a046ee5.
I fixed it in the following commit. |
Thank you for the detail. Now I think additional tests are unnecessary.
Thanks |
|
The CI runs
# on the trunk
$ mvn clean install -DskipTests -DskipShade
# on the PR
$ ./start-build-env.sh ubuntu_24
> mvn -pl hadoop-hdfs-project/hadoop-hdfs test -Dtest=org.apache.hadoop.cli.TestHDFSCLI # Fail
> mvn -pl hadoop-hdfs-project/hadoop-hdfs -am test -Dtest=org.apache.hadoop.cli.TestHDFSCLI. # Success
> mvn -pl hadoop-common-project/hadoop-common,hadoop-hdfs-project/hadoop-hdfs test -Dtest=org.apache.hadoop.cli.TestHDFSCLI # Success
# on the PR
$ mvn clean install -DskipTests -DskipShade
$ ./start-build-env.sh ubuntu_24
> mvn -pl hadoop-hdfs-project/hadoop-hdfs test -Dtest=org.apache.hadoop.cli.TestHDFSCLI # Success |
4ceccbc to
928337a
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Description of PR
Add match expressions to find command.
This pull request is based on the patch attached to the ticket in HADOOP-10579 and HADOOP-10580.
The main changes from the original patch are as follows:
a(all) to the symbolic notation target inPerm.java-regextypeequals("")withisEmpty()throw new IOExceptionwiththrow new IllegalArgumentExceptionHow was this patch tested?
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/findon local.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html