HADOOP-19863. Incorrect Vectored IO metrics from Local Filesystem.#8447
Open
steveloughran wants to merge 4 commits intotrunkfrom
Open
HADOOP-19863. Incorrect Vectored IO metrics from Local Filesystem.#8447steveloughran wants to merge 4 commits intotrunkfrom
steveloughran wants to merge 4 commits intotrunkfrom
Conversation
Contributor
Author
fwiw saw that on ide test runs, but not cli. also, should do this check through LocalFS, where raw local is behind the scenes |
Contributor
Author
|
if this is failing, then
#2 isn't necessarily wrong as we need to round up for crc checking and with coalescing, merge ranges. I'll just assert the number goes up and not worry about the exact number |
Contributed by Steve Loughran.
+ validate properly
* add count of vector operations * assert of #of bytes read relaxed as tests were failing ..suspect vector reads are reading more to handle checksums &c. Even if more is read, provided the scatter/gather IO parallelises, it is faster.
fca7608 to
06bd286
Compare
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Update filesystem and io statistics with bytes read from
successful vector reads.
How was this patch tested?
extended contract tests.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html