Skip to content

HADOOP-19863. Incorrect Vectored IO metrics from Local Filesystem.#8447

Open
steveloughran wants to merge 4 commits intotrunkfrom
pr/HADOOP-19863-vector-read-metrics
Open

HADOOP-19863. Incorrect Vectored IO metrics from Local Filesystem.#8447
steveloughran wants to merge 4 commits intotrunkfrom
pr/HADOOP-19863-vector-read-metrics

Conversation

@steveloughran
Copy link
Copy Markdown
Contributor

Description of PR

Update filesystem and io statistics with bytes read from
successful vector reads.

How was this patch tested?

extended contract tests.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

@steveloughran
Copy link
Copy Markdown
Contributor Author

Cannot invoke "org.apache.hadoop.fs.FileSystem.openFile(org.apache.hadoop.fs.Path)" because "fs" is null

fwiw saw that on ide test runs, but not cli.

also, should do this check through LocalFS, where raw local is behind the scenes

@steveloughran
Copy link
Copy Markdown
Contributor Author

if this is failing, then

  1. bad counting logic
  2. the number of bytes read really is different from that requested.

#2 isn't necessarily wrong as we need to round up for crc checking and with coalescing, merge ranges.

I'll just assert the number goes up and not worry about the exact number

* add count of vector operations
* assert of #of bytes read relaxed as tests were failing
  ..suspect vector reads are reading more to handle checksums &c.
Even if more is read, provided the scatter/gather IO parallelises, it is faster.
@asf-gitbox-commits asf-gitbox-commits force-pushed the pr/HADOOP-19863-vector-read-metrics branch from fca7608 to 06bd286 Compare April 29, 2026 17:02
@apache apache deleted a comment from hadoop-yetus Apr 29, 2026
@apache apache deleted a comment from hadoop-yetus Apr 29, 2026
@apache apache deleted a comment from hadoop-yetus Apr 29, 2026
@hadoop-yetus
Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 28m 58s trunk passed
+1 💚 compile 8m 46s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 compile 8m 58s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 checkstyle 0m 50s trunk passed
+1 💚 mvnsite 1m 13s trunk passed
+1 💚 javadoc 0m 51s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 0m 52s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 1m 48s trunk passed
+1 💚 shadedclient 16m 44s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 42s the patch passed
+1 💚 compile 8m 15s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javac 8m 15s the patch passed
+1 💚 compile 9m 0s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 javac 9m 0s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 52s the patch passed
+1 💚 mvnsite 1m 11s the patch passed
+1 💚 javadoc 0m 52s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 0m 53s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 1m 55s the patch passed
+1 💚 shadedclient 17m 13s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 41s hadoop-common in the patch passed.
+1 💚 asflicense 0m 48s The patch does not generate ASF License warnings.
129m 56s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8447/4/artifact/out/Dockerfile
GITHUB PR #8447
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux ca463d92f4f9 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 06bd286
Default Java Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8447/4/testReport/
Max. process+thread count 1279 (vs. ulimit of 10000)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8447/4/console
versions git=2.43.0 maven=3.9.11 spotbugs=4.9.7
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants