HADOOP-19857. Enable unit tests on GHA#8452
Open
pan3793 wants to merge 37 commits intoapache:trunkfrom
Open
Conversation
pan3793
force-pushed
the
gha-enable-tests
branch
from
ee48d49 to
2f14ca3
Compare
pan3793
commented
Apr 22, 2026
pan3793
commented
Apr 22, 2026
| options: --user ${{ needs.build-image.outputs.uid }} | ||
| strategy: | ||
| fail-fast: false | ||
| max-parallel: 6 |
Member
Author
There was a problem hiding this comment.
note, this runs in the contributor's forked repo, it's free but has concurrency limitations, also remember that each split requires a build, larger parallel splits consume more overall time.
pan3793
commented
Apr 22, 2026
| include: | ||
| - comment: hdfs | ||
| modules: | ||
| -pl :hadoop-hdfs |
Member
Author
There was a problem hiding this comment.
IIRC, this single module takes more than 4 hours to complete (even though more than 20 tests are excluded for now), we need to improve the slow tests and use tags to split it into more groups
Member
Author
There was a problem hiding this comment.
okay, it actually takes 5 hours to complete (with ~30 tests excluded).
I split it into 2 groups:
- slow, ~70 classes, which single test class takes more than 60s, all of them take ~150min
- other, the rest of them
hope it can be completed in 2.5 hours next round
Member
Author
There was a problem hiding this comment.
@ajfabbri, given the situation, I expect we may
- exclude fewer than 200 test classes
- keep others running stable on GHA, within 3 hours
Member
Author
There was a problem hiding this comment.
not ready but almost here, with ~160 test suites (classes) excluded, all remaining tests run successfully in 2.5h
https://github.com/pan3793/hadoop/actions/runs/24870046901
I still need to re-run several rounds to ensure the initial test list runs stably.
@ajfabbri @steveloughran @slfan1989 would be great if you could take a look first.
Contributor
There was a problem hiding this comment.
@pan3793 Will look at it when I get back. I am on vacation until tomorrow night.
Contributor
There was a problem hiding this comment.
This seems fine. We have some work to do on improving tests: We need to make them faster, and completely eliminate flaky tests (ideally). This gives us an iterative way to tackle it. 👍
pan3793
force-pushed
the
gha-enable-tests
branch
4 times, most recently
from
8a5ffe4 to
1dcdec9
Compare
pan3793
force-pushed
the
gha-enable-tests
branch
3 times, most recently
from
1a874a0 to
5ee44de
Compare
|
💔 -1 overall
This message was automatically generated. |
…-hbase-tests" This reverts commit d9f030c.
pan3793
changed the title
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
@ajfabbri @slfan1989 @steveloughran, this is ready for review. for stability, please check https://github.com/pan3793/hadoop/actions/workflows/build_and_test.yml?query=branch%3Agha-enable-tests |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
This PR enables running unit tests in parallel on GitHub Actions, with ~150 test suites(classes) excluded due to flaky or consistently failing on GHA that need to be fixed later, all of the remaining test suites take ~2.5 hours to complete. As a comparison, Jenkins takes ~30 hours.
How was this patch tested?
GHA report.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
No AI usage.