Skip to content

HADOOP-19878. Upgrade to Netty 4.1.113.Final due to CVEs#8469

Open
pjfanning wants to merge 1 commit intoapache:trunkfrom
pjfanning:HADOOP-19878-netty
Open

HADOOP-19878. Upgrade to Netty 4.1.113.Final due to CVEs#8469
pjfanning wants to merge 1 commit intoapache:trunkfrom
pjfanning:HADOOP-19878-netty

Conversation

@pjfanning
Copy link
Copy Markdown
Member

Description of PR

https://issues.apache.org/jira/browse/HADOOP-19878

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

Copy link
Copy Markdown
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending the build.

@pjfanning we really an upgrade marathon don't we, where everything which can be upgraded is (trunk, and 3.5) and anything which still works on java8 is done for the 3.4 branch. Then we can think of new releases

Copy link
Copy Markdown
Contributor

@ajfabbri ajfabbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending jenkins/pr-merge CI passing. We can ignore the PR update / Build (pull_request_target) — Workflow run detection failed check for now: We are adding new github actions-based CI which requires enabling actions in your forked repo to get past that error, but it is not a requirement yet.

Comment thread LICENSE-binary
io.netty:netty-codec-http2:4.1.133.Final
io.netty:netty-codec-memcache:4.1.133.Final
io.netty:netty-codec-mqtt:4.1.133.Final
io.netty:netty-codec-redis:4.1.133.Final
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all those netty libs used by hadoop? I don't think hadoop requires netty-codec-redis ...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels like there is a separate task to revisit the entire LICENSE-binary file - I guarantee that this is not the only is it/isn't it correct line in the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants