HBASE-29226 Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1 #6783

NihalJain · 2025-03-11T20:31:01Z

Please find a detailed summary of all changes as below:

Dependencies

Replaced hbase-shaded-jetty i.e. Jetty 9 with hbase-shaded-jetty-12-plus-core and hbase-shaded-jetty-12-plus-ee8 i.e. Jetty 12 EE8
Upgrade servlet.api.version to 4.0.1
Upgrade tomcat.jasper.version to 9.0.102

Code Adjustments

Modified import statements to use org.eclipse.jetty.ee8 etc. as per Jetty 12
Replace HandlerCollection with Handler.Sequence
Adjust error handlers' set logic based on available methods
Change logDir path to be in canonical format as otherwise, we get 404 in case we have .. in static path
Remove usage of MultiException as it is not removed in Jetty 12; Replace with exception.addSuppressed in HttpServer.java. Copied ifExceptionThrow() method from Jetty 9 to retain exception handling behavior.
Modify assignment: webServer.getHandlers() with new return type: Array to List
Replaced Constraint with ServletConstraint
Added LogLevelExceptionUtils.java to handle HTML error response for log levels as connection.getResponseMessage() now returns error code as string in message and hence causes test failure otherwise
Allow javax as xsd files at javax/servlet/resources come via org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus

Test Adjustments

Update checkBindAddress() to call server.start() else testBindAddress() fails with NPE. Verified doing same without Jetty 12 works as well.
Replace JSON.parse() with new JSON().fromJSON() and JSON.toString() with new JSON().toJSON()
Update app name from ".." to "" as it fails with IllegalArgumentException otherwise
Update MockHttpApiRule where we replace AbstractHandler with Handler.Abstract and adjust code based on new interface
Deleted webdefaults.xml. Need to see if still needed.
Added necessary compliance rules for URI validation, required by tests and possibly users as well. Add note for what fails if these rules are not there in tests

References

Umbrealla at HBASE-29224
Discussion at https://lists.apache.org/thread/bkrfm705kqd3bqzyvo7jv46t6p64x2n5
Dependent thirdparty change at HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty hbase-thirdparty#131

- Also consume hbase-thridparty having the new jetty 12 ee8 module

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java

hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/NamespacesResource.java

NihalJain · 2025-03-11T20:41:49Z

...shaded/hbase-shaded-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh

@@ -96,6 +96,8 @@ allowed_expr+="|^PropertyList-1.0.dtd$"
 # Shaded jetty resources
 allowed_expr+="|^about.html$"
 allowed_expr+="|^jetty-dir.css$"
+# Required by jetty 12 on ee8


Had to do this to include xsd file in javax/servlet/resources coming from org.apache.hbase.thirdparty:hbase-shaded-jetty-ee8. Else if we exclude the folder in thirdparty starting hbase fails with following:

2025-03-10T13:02:47,631 ERROR [main] master.HMasterCommandLine: Master exiting java.lang.RuntimeException: Failed construction of Master: class org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMasternull at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:128) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:224) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.LocalHBaseCluster.<init>(LocalHBaseCluster.java:171) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.LocalHBaseCluster.<init>(LocalHBaseCluster.java:114) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:241) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:147) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) ~[hadoop-common-3.4.1.jar:?] at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:140) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3489) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] Caused by: java.io.IOException: Unable to initialize WebAppContext at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1230) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:157) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:350) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:522) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.<init>(HMasterCommandLine.java:322) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?] at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?] at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] ... 8 more Caused by: java.lang.ExceptionInInitializerError at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebXmlConfiguration.preConfigure(WebXmlConfiguration.java:61) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.Configurations.preConfigure(Configurations.java:407) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.preConfigure(WebAppContext.java:470) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.doStart(WebAppContext.java:500) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:113) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.lambda$doStart$0(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler$ScopedContext.call(ContextHandler.java:1452) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.nested.ContextHandler$CoreContextHandler.doStart(ContextHandler.java:2271) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:132) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.start(Server.java:641) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.doStart(Server.java:582) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1209) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:157) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:350) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:522) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.<init>(HMasterCommandLine.java:322) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?] at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?] at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] ... 8 more Caused by: java.lang.IllegalStateException: Unable to instantiate WebDescriptorParser at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor.newParser(WebDescriptor.java:89) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor.<clinit>(WebDescriptor.java:37) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebXmlConfiguration.preConfigure(WebXmlConfiguration.java:61) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.Configurations.preConfigure(Configurations.java:407) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.preConfigure(WebAppContext.java:470) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.doStart(WebAppContext.java:500) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:113) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.lambda$doStart$0(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler$ScopedContext.call(ContextHandler.java:1452) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.nested.ContextHandler$CoreContextHandler.doStart(ContextHandler.java:2271) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:132) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.start(Server.java:641) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.doStart(Server.java:582) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1209) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:157) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:350) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:522) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.<init>(HMasterCommandLine.java:322) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?] at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?] at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] ... 8 more Caused by: java.io.FileNotFoundException: Unable to find ref [javax/servlet/resources/javaee_8.xsd] in same archive as javax.servlet.Servlet: file:/Users/nihjain/code/os/temp2/hbase/hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.servlet-api-3.1.0.jar at org.apache.hbase.thirdparty.org.eclipse.jetty.xml.BaseClassCatalog$CatalogReader.getMapping(BaseClassCatalog.java:112) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.xml.BaseClassCatalog$CatalogReader.parse(BaseClassCatalog.java:84) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.xml.BaseClassCatalog.load(BaseClassCatalog.java:56) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.xml.XmlParser.addCatalog(XmlParser.java:220) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor$WebDescriptorParser.<init>(WebDescriptor.java:101) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor.newParser(WebDescriptor.java:87) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor.<clinit>(WebDescriptor.java:37) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebXmlConfiguration.preConfigure(WebXmlConfiguration.java:61) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.Configurations.preConfigure(Configurations.java:407) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.preConfigure(WebAppContext.java:470) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.doStart(WebAppContext.java:500) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:113) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.lambda$doStart$0(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler$ScopedContext.call(ContextHandler.java:1452) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.nested.ContextHandler$CoreContextHandler.doStart(ContextHandler.java:2271) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:132) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.start(Server.java:641) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.doStart(Server.java:582) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?] at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1209) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:157) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:350) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:522) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.<init>(HMasterCommandLine.java:322) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?] at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?] at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] ... 8 more

NihalJain · 2025-03-11T20:42:54Z

pom.xml

@@ -863,9 +863,9 @@
    <jackson.version>2.17.2</jackson.version>
    <jackson.databind.version>2.17.2</jackson.databind.version>
    <jaxb-api.version>2.3.1</jaxb-api.version>
-    <servlet.api.version>3.1.0</servlet.api.version>
+    <servlet.api.version>4.0.1</servlet.api.version>


just a note: hbase worked with 3.1.0 as well but as per https://stackoverflow.com/questions/77007560/missing-jetty-servlet-12-0-0-dependency we should be on 4.x

NihalJain · 2025-03-11T20:43:24Z

pom.xml

    <!-- for.exclusion version are NOT for direct dependencies. To use the provided
    scope to transitively exclude some transitive dependencies, we need to specify
    some existing version to for maven. -->
-    <tomcat.version.for.exclusion>9.0.93</tomcat.version.for.exclusion>
+    <tomcat.version.for.exclusion>${tomcat.jasper.version}</tomcat.version.for.exclusion>


todo: fix existing comment, we actually depend on tomcat in hbase

hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java

NihalJain · 2025-03-27T12:36:37Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java

@@ -267,7 +266,11 @@ private void process(String urlString) throws Exception {

      HttpURLConnection connection = connect(url);

-      HttpExceptionUtils.validateResponse(connection, 200);
+      // We implement the validateResponse method inside hbase to handle for HTML response.


added note for reviewers' ease, let me know if should drop before merge

also previous method was not useful, the error is HTML but it parses JSON

NihalJain · 2025-03-27T12:37:03Z

hbase-http/src/test/java/org/apache/hadoop/hbase/http/log/TestLogLevel.java

@@ -235,7 +235,10 @@ private boolean validateCommand(String[] args) {
   * @throws Exception if unable to create or start a Jetty server
   */
  private HttpServer createServer(String protocol, boolean isSpnego) throws Exception {
-    HttpServer.Builder builder = new HttpServer.Builder().setName("..")
+    // Changed to "" as ".." moves it a steps back in path because the path is relative to the


added note for reviewers' ease, let me know if should drop before merge

Strange thet it worked with jetty 9.

I think this is correct behavior. only not sure how it worked with jetty9. also not sure why we set this as name in first place!

NihalJain · 2025-03-27T12:38:00Z

hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTServer.java

+    // Refer to https://github.com/jetty/jetty.project/issues/11890#issuecomment-2156449534
+    // We must set a URI compliance to allow for this violation so that client
+    // requests are not automatically rejected. We have tests which rely on this behavior.
+    // TODO Discuss Should we set below to UriCompliance.LEGACY instead of cherry-picking?


To reviewers, WDYT?

I think this is fine.
This signals that we may want to clean this up properly at some point.

Ok so will stick to cherry picking then

todo: remove todo note

NihalJain · 2025-03-27T12:38:13Z

hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestGetAndPutResource.java

@@ -321,6 +321,8 @@ public void testLatestCellGetJSON() throws IOException {

  @Test
  public void testURLEncodedKey() throws IOException, JAXBException {
+    // Requires UriCompliance.Violation.AMBIGUOUS_PATH_SEPARATOR


added note for reviewers' ease, let me know if should drop before merge

Maybe we should just consider fixing these.

A new major version could be the opportunity to clean this up, even if we break compatibility.

I'm not sure if we CAN fix it, I haven't really checked, just in principle.

Maybe we should just consider fixing these.

A new major version could be the opportunity to clean this up, even if we break compatibility.

Need to dig deeper in the test again. Will share info on what they are doing, hence marked them explicitly so that we can fix/disallow behaviour, if possible, today or in future

hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestSecureRESTServer.java

NihalJain · 2025-03-27T13:29:46Z

...il/src/main/resources/org/apache/hadoop/hbase/shaded/org/eclipse/jetty/webapp/webdefault.xml

-<!--
-Copyright (C) Jetty Authors
-
-Licensed under the Apache License, Version 2.0 (the "License");


Not sure why we even had this file in our codebase. Tried deleting to find regression, all UTs ran fine locally. Anyone could help me with how to validate if this is even needed?

This should be coming from the ee support in jetty.
Though I believe we're not using the web.xml server config at all in HBase.

stoty

The null Exception looks like a bug to me, the rest are just comments/questions.

stoty · 2025-03-28T16:48:08Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

-      RequestLogHandler requestLogHandler = new RequestLogHandler();
-      requestLogHandler.setRequestLog(requestLog);
-      handlerCollection.addHandler(requestLogHandler);
+      webServer.setRequestLog(requestLog);


So loggers are not handlers now ?

Yes, please refer https://jetty.org/docs/jetty/12/programming-guide/migration/11-to-12.html#api-changes-handler-requestlog

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

stoty · 2025-03-28T16:50:06Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

-      webServer.setErrorHandler(new ErrorHandler());
-      webServer.getErrorHandler().setShowStacks(false);
+      ErrorHandler errorHanlder = new ErrorHandler();
+      errorHanlder.setShowStacks(false);


would getting the handler and setting it not work ?
I'm fine with the change, just curious.

The method has been removed in jetty 12: https://javadoc.io/static/org.eclipse.jetty/jetty-server/12.0.18/org.eclipse.jetty.server/org/eclipse/jetty/server/Request.Handler.html vs https://javadoc.io/static/org.eclipse.jetty/jetty-server/9.4.57.v20241219/org/eclipse/jetty/server/handler/ErrorHandler.html#setShowStacks(boolean)

stoty · 2025-03-28T16:51:33Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

@@ -1213,14 +1212,14 @@ public void start() throws IOException {
      } catch (IOException ex) {
        LOG.info("HttpServer.start() threw a non Bind IOException", ex);
        throw ex;
-      } catch (MultiException ex) {
+      } catch (Exception ex) {


So Jetty just throws Exception here ?

Ah dug a little harder found alternate for old exception, let me fall back to that and revet to old logic: https://github.com/jetty/jetty.project/blob/ccdbe1742eac511914869a53f0efc2075775d0b8/jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ExceptionUtil.java#L251 vs https://github.com/jetty/jetty.project/blob/jetty-9.4.x/jetty-util/src/main/java/org/eclipse/jetty/util/MultiException.java

HBase uses Jetty's method to check and throw as below.

/** * Throw a {@link Throwable} as a checked {@link Exception} if it * cannot be thrown as unchecked. * @param throwable The {@link Throwable} to throw or null. * @throws Error If the passed {@link Throwable} is an {@link Error}. * @throws Exception Otherwise, if the passed {@link Throwable} is not null. */ public static void ifExceptionThrow(Throwable throwable) throws Error, Exception { if (throwable == null) return; if (throwable instanceof Error error) throw error; if (throwable instanceof Exception exception) throw exception; throw new RuntimeException(throwable); }

Refer https://github.com/jetty/jetty.project/blob/ccdbe1742eac511914869a53f0efc2075775d0b8/jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ExceptionUtil.java#L81

Older impl:

/** * Throw a multiexception. * If this multi exception is empty then no action is taken. If it * contains a single exception that is thrown, otherwise the this * multi exception is thrown. * * @throws Exception the Error or Exception if nested is 1, or the MultiException itself if nested is more than 1. */ public void ifExceptionThrow() throws Exception { if (nested == null) return; switch (nested.size()) { case 0: break; case 1: Throwable th = nested.get(0); if (th instanceof Error) throw (Error)th; if (th instanceof Exception) throw (Exception)th; throw new MultiException(nested); default: throw new MultiException(nested); } }

Refer https://github.com/jetty/jetty.project/blob/e3fa9466633db6bf36e0eb0d17e3de166c788ede/jetty-util/src/main/java/org/eclipse/jetty/util/MultiException.java#L104

Maybe we should catch Error as well now? WDYT?

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

stoty · 2025-03-28T17:03:43Z

hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTServer.java

+    // Refer to https://github.com/jetty/jetty.project/issues/11890#issuecomment-2156449534
+    // We must set a URI compliance to allow for this violation so that client
+    // requests are not automatically rejected. We have tests which rely on this behavior.
+    // TODO Discuss Should we set below to UriCompliance.LEGACY instead of cherry-picking?


I think this is fine.
This signals that we may want to clean this up properly at some point.

stoty · 2025-03-28T17:04:52Z

hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestGetAndPutResource.java

@@ -321,6 +321,8 @@ public void testLatestCellGetJSON() throws IOException {

  @Test
  public void testURLEncodedKey() throws IOException, JAXBException {
+    // Requires UriCompliance.Violation.AMBIGUOUS_PATH_SEPARATOR


Maybe we should just consider fixing these.

A new major version could be the opportunity to clean this up, even if we break compatibility.

stoty · 2025-03-28T17:05:18Z

hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestGetAndPutResource.java

@@ -321,6 +321,8 @@ public void testLatestCellGetJSON() throws IOException {

  @Test
  public void testURLEncodedKey() throws IOException, JAXBException {
+    // Requires UriCompliance.Violation.AMBIGUOUS_PATH_SEPARATOR


I'm not sure if we CAN fix it, I haven't really checked, just in principle.

...shaded/hbase-shaded-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh

...-shaded-with-hadoop-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh

NihalJain · 2025-03-28T18:44:47Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

-      logContext.setResourceBase(logDir);
+      // We are doing this as otherwise jetty 12 is not handling /dir0/dir1/../dir2
+      String logDirCanonical = Paths.get(logDir).toFile().getCanonicalPath();
+      logContext.setResourceBase(logDirCanonical);


for context of reviewers: i think its a bug in jetty, similar to jetty/jetty.project#12833
Also refer https://www.eclipse.org/lists/jetty-users/msg10296.html

Consider filing a Jetty bug if you can confirm it's a bug.

Yes let me try to write a minimal jetty server w/o hbase, run same logic with jetty 9 and 12, confirm issue and finally submit.

Added bug demo at https://github.com/NihalJain/jetty_log_dir_issue.

For Jetty 12:

Refer https://github.com/NihalJain/jetty_log_dir_issue/actions/runs/14220016149/job/39845473906

For Jetty 9:

Refer https://github.com/NihalJain/jetty_log_dir_issue/actions/runs/14220016167/job/39845473985

Will report to jetty team with this minimal demo.

NihalJain · 2025-03-28T18:48:19Z

The null Exception looks like a bug to me, the rest are just comments/questions.

I reverted to old code, the class was just refactored. so the null bug should be fixed now.

Apache-HBase · 2025-03-28T19:10:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 59s		master passed
+1 💚	compile	2m 8s		master passed
+1 💚	javadoc	3m 59s		master passed
+1 💚	shadedjars	5m 50s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 8s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 10s	/patch-mvninstall-root.txt	root in the patch failed.
-1 ❌	compile	0m 8s	/patch-compile-root.txt	root in the patch failed.
-0 ⚠️	javac	0m 8s	/patch-compile-root.txt	root in the patch failed.
-0 ⚠️	javadoc	0m 9s	/patch-javadoc-root.txt	root in the patch failed.
-0 ⚠️	javadoc	0m 6s	/patch-javadoc-hbase-http.txt	hbase-http in the patch failed.
-0 ⚠️	javadoc	0m 7s	/patch-javadoc-hbase-it.txt	hbase-it in the patch failed.
-0 ⚠️	javadoc	0m 6s	/patch-javadoc-hbase-rest.txt	hbase-rest in the patch failed.
-0 ⚠️	javadoc	0m 6s	/patch-javadoc-hbase-server.txt	hbase-server in the patch failed.
-0 ⚠️	javadoc	0m 6s	/patch-javadoc-hbase-shaded_hbase-shaded-testing-util.txt	hbase-shaded-testing-util in the patch failed.
-0 ⚠️	javadoc	0m 6s	/patch-javadoc-hbase-thrift.txt	hbase-thrift in the patch failed.
-1 ❌	shadedjars	0m 11s		patch has 23 errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	0m 10s	/patch-unit-root.txt	root in the patch failed.
		19m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6783
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 218aa67bf6d4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `790d320`
Default Java	Eclipse Adoptium-17.0.11+9
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/6/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/6/testReport/
Max. process+thread count	173 (vs. ulimit of 30000)
modules	C: . hbase-http hbase-it hbase-rest hbase-server hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-thrift U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-03-28T19:22:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 13s		master passed
+1 💚	compile	7m 57s		master passed
+1 💚	checkstyle	1m 14s		master passed
+1 💚	spotbugs	11m 23s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 10s	/patch-mvninstall-root.txt	root in the patch failed.
-1 ❌	compile	0m 12s	/patch-compile-root.txt	root in the patch failed.
-0 ⚠️	javac	0m 12s	/patch-compile-root.txt	root in the patch failed.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 6s	/buildtool-patch-checkstyle-root.txt	The patch fails to run checkstyle in root
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	xmllint	0m 1s		No new issues.
-1 ❌	spotbugs	0m 12s	/patch-spotbugs-root.txt	root in the patch failed.
-1 ❌	spotbugs	0m 9s	/patch-spotbugs-hbase-http.txt	hbase-http in the patch failed.
-1 ❌	spotbugs	0m 7s	/patch-spotbugs-hbase-it.txt	hbase-it in the patch failed.
-1 ❌	spotbugs	0m 8s	/patch-spotbugs-hbase-rest.txt	hbase-rest in the patch failed.
-1 ❌	spotbugs	0m 6s	/patch-spotbugs-hbase-server.txt	hbase-server in the patch failed.
-1 ❌	spotbugs	0m 6s	/patch-spotbugs-hbase-thrift.txt	hbase-thrift in the patch failed.
-1 ❌	hadoopcheck	0m 7s		The patch causes 13 errors with Hadoop v3.3.6.
-1 ❌	hadoopcheck	0m 15s		The patch causes 13 errors with Hadoop v3.4.0.
-1 ❌	spotless	0m 16s		patch has 39 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 59s		The patch does not generate ASF License warnings.
		30m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6783
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti shellcheck shelldocs
uname	Linux 8f4c2ebd7f43 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `790d320`
Default Java	Eclipse Adoptium-17.0.11+9
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/6/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/6/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/6/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	191 (vs. ulimit of 30000)
modules	C: . hbase-http hbase-it hbase-rest hbase-server hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-thrift U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/6/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-03-28T19:38:58Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

@@ -1327,9 +1327,9 @@ public void stop() throws Exception {

  }

-  private MultiException addMultiException(MultiException exception, Exception e) {
+  private ExceptionUtil.MultiException addMultiException(ExceptionUtil.MultiException exception, Exception e) {


run spotless

stoty · 2025-03-29T08:37:33Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

@@ -1213,14 +1212,14 @@ public void start() throws IOException {
      } catch (IOException ex) {
        LOG.info("HttpServer.start() threw a non Bind IOException", ex);
        throw ex;
-      } catch (MultiException ex) {
+      } catch (Exception ex) {
        LOG.info("HttpServer.start() threw a MultiException", ex);


Fix the comment as well?

NihalJain · 2025-04-02T13:07:12Z

Created jetty/jetty.project#12958

[WIP] Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1

cceaf51

- Also consume hbase-thridparty having the new jetty 12 ee8 module

NihalJain marked this pull request as draft March 11, 2025 20:31

This comment was marked as duplicate.

Sign in to view

NihalJain commented Mar 11, 2025

View reviewed changes

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java Outdated Show resolved Hide resolved

NihalJain commented Mar 11, 2025

View reviewed changes

hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java Outdated Show resolved Hide resolved

NihalJain commented Mar 11, 2025

View reviewed changes

hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/NamespacesResource.java Outdated Show resolved Hide resolved

NihalJain commented Mar 11, 2025

View reviewed changes

hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

NihalJain mentioned this pull request Mar 11, 2025

Issue #12828 support relative uris for Response.encodeURI jetty/jetty.project#12833

Merged

Make changes to fix UTs, fix /logs page not loading issue etc.

5172b2b

NihalJain changed the title ~~[WIP] Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1~~ HBASE-29226 Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1 Mar 27, 2025

Fix spotless

ae3d1fa

NihalJain commented Mar 27, 2025

View reviewed changes

hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestSecureRESTServer.java Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

NihalJain marked this pull request as ready for review March 27, 2025 12:56

This comment has been minimized.

Sign in to view

NihalJain commented Mar 27, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Make changes to test EE8 + EE9 in single module

fb0564a

This comment has been minimized.

Sign in to view

NihalJain mentioned this pull request Mar 28, 2025

HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty apache/hbase-thirdparty#131

Open

Update as per thirdparty changes post review

2ba5683

NihalJain requested review from apurtell, ndimiduk, stoty and Apache9 March 28, 2025 16:38

This comment has been minimized.

Sign in to view

stoty requested changes Mar 28, 2025

View reviewed changes

NihalJain added 2 commits March 29, 2025 00:06

Fix type and use ExceptionUtil.MultiException and revert to old code

4ef781a

ee9 -> ee9+

790d320

NihalJain commented Mar 28, 2025

View reviewed changes

NihalJain requested a review from stoty March 28, 2025 18:49

NihalJain commented Mar 28, 2025

View reviewed changes

stoty reviewed Mar 29, 2025

View reviewed changes

HBASE-29226 Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1 #6783

Are you sure you want to change the base?

HBASE-29226 Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1 #6783

Conversation

NihalJain commented Mar 11, 2025 • edited Loading

This comment was marked as duplicate.

NihalJain Mar 11, 2025 • edited Loading

Choose a reason for hiding this comment

NihalJain Mar 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NihalJain Mar 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NihalJain Mar 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NihalJain Mar 28, 2025 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

stoty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NihalJain Mar 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NihalJain Apr 1, 2025 • edited Loading

Choose a reason for hiding this comment

NihalJain Apr 2, 2025 • edited Loading

Choose a reason for hiding this comment

NihalJain commented Mar 28, 2025

Apache-HBase commented Mar 28, 2025

Apache-HBase commented Mar 28, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NihalJain commented Apr 2, 2025 • edited Loading

NihalJain commented Mar 11, 2025 •

edited

Loading

NihalJain Mar 11, 2025 •

edited

Loading

NihalJain Mar 11, 2025 •

edited

Loading

NihalJain Mar 28, 2025 •

edited

Loading

NihalJain Mar 28, 2025 •

edited

Loading

NihalJain Mar 28, 2025 •

edited

Loading

NihalJain Mar 28, 2025 •

edited

Loading

NihalJain Apr 1, 2025 •

edited

Loading

NihalJain Apr 2, 2025 •

edited

Loading

NihalJain commented Apr 2, 2025 •

edited

Loading