Skip to content

Conversation

@PDavid
Copy link
Contributor

@PDavid PDavid commented Oct 27, 2025

[ADDENDUM] TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build.

@PDavid PDavid self-assigned this Oct 27, 2025
@PDavid PDavid added the bug label Oct 27, 2025
conf.setBoolean("hbase.master.ui.fragmentation.enabled", true);
Map<String, Integer> fragmentationInfo = MasterStatusUtil.getFragmentationInfo(master, conf);
assertNotNull(fragmentationInfo);
assertEquals(1, fragmentationInfo.size());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected or something is broken?

@PDavid PDavid marked this pull request as ready for review October 28, 2025 08:12
@PDavid PDavid requested review from Apache9 and stoty October 28, 2025 12:01
@NihalJain
Copy link
Contributor

Hi @PDavid is this an addendum? you seem to be using an existing jira title here. Also is this the right fix, may be checkon what should be the expected assertion?

@PDavid
Copy link
Contributor Author

PDavid commented Oct 30, 2025

Hi @PDavid is this an addendum? you seem to be using an existing jira title here.

Hi @NihalJain,
Thanks, yes this would need to be an addendum.

Also is this the right fix, may be checkon what should be the expected assertion?

To be completely honest I'm having trouble finding out the right value to expect in the assertion. Locally was always 1 but in the nightly build it was 11:
https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1359/testReport/junit/org.apache.hadoop.hbase.master.http/TestMasterStatusUtil/health_checks___yetus_jdk17_hadoop3_backwards_compatibility_checks___testGetFragmentationInfoTurnedOn/

I also thought about checking that the map is not empty. 🤔

@PDavid PDavid changed the title HBASE-29223 Fix TestMasterStatusUtil [ADDENDUM] HBASE-29223 Fix TestMasterStatusUtil Oct 31, 2025
TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build
@PDavid PDavid force-pushed the HBASE-29223-TestMasterStatusUtil-fix branch from bba011e to bcd72e1 Compare October 31, 2025 12:29
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 14s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 6m 43s master passed
+1 💚 compile 6m 2s master passed
+1 💚 checkstyle 1m 43s master passed
+1 💚 spotbugs 2m 59s master passed
+1 💚 spotless 1m 16s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 6m 2s the patch passed
+1 💚 compile 5m 43s the patch passed
+1 💚 javac 5m 43s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 22s the patch passed
+1 💚 spotbugs 2m 53s the patch passed
+1 💚 hadoopcheck 17m 6s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 1m 15s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
64m 58s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7416/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7416
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 4fab849aa8dd 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bcd72e1
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 71 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7416/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants