-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[ADDENDUM] HBASE-29223 Fix TestMasterStatusUtil #7416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| conf.setBoolean("hbase.master.ui.fragmentation.enabled", true); | ||
| Map<String, Integer> fragmentationInfo = MasterStatusUtil.getFragmentationInfo(master, conf); | ||
| assertNotNull(fragmentationInfo); | ||
| assertEquals(1, fragmentationInfo.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this locally was always 1 but in the nightly build it was 11:
https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1359/testReport/junit/org.apache.hadoop.hbase.master.http/TestMasterStatusUtil/health_checks___yetus_jdk17_hadoop3_backwards_compatibility_checks___testGetFragmentationInfoTurnedOn/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this expected or something is broken?
|
Hi @PDavid is this an addendum? you seem to be using an existing jira title here. Also is this the right fix, may be checkon what should be the expected assertion? |
Hi @NihalJain,
To be completely honest I'm having trouble finding out the right value to expect in the assertion. Locally was always 1 but in the nightly build it was 11: I also thought about checking that the map is not empty. 🤔 |
TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build
…ationInfoTurnedOn
bba011e to
bcd72e1
Compare
|
🎊 +1 overall
This message was automatically generated. |
[ADDENDUM] TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build.