-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29721 Add validation for Mutations without column families #7469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e62b4f8 to
6a3855e
Compare
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
22eeff9 to
9c3ad02
Compare
9c3ad02 to
59beea6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
junegunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree that empty mutations are mistakes that we should identify and inform users about (we already do so in single-mutation methods as you mentioned in the Jira).
However, we can't be 100% sure that no users rely on the current behavior of allowing empty mutations. It's a classic spacebar-heating problem. So, while I don't think we should really be concerned about it, I'd like to hear the opinions of PMC members, as it might disrupt existing client applications.
/cc @Apache9
https://issues.apache.org/jira/browse/HBASE-29721