Skip to content

HIVE-28917: NPE in merge statement when checking nullability of joini… #5781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

HIVE-28917: NPE in merge statement when checking nullability of joini… #5781

merged 3 commits into from
May 15, 2025

Conversation

soumyakanti3578
Copy link
Contributor

@soumyakanti3578 soumyakanti3578 commented Apr 22, 2025 •
edited
Loading

…ng column in matched clause

What changes were proposed in this pull request?

When TOK_FROM is not present in the AST for MERGE statements, return DestClausePrefix.MERGE.

Why are the changes needed?

Without this we could get an NPE as explained in HIVE-28917

Does this PR introduce any user-facing change?

No

How was this patch tested?

mvn test -pl itests/qtest-iceberg -Piceberg -Pitests -Dtest=TestIcebergNegativeCliDriver -Dtest.output.overwrite=true -Dqfile="merge_with_null_check_on_joining_col.q"

zabetak
zabetak requested changes Apr 22, 2025
View reviewed changes
@soumyakanti3578 soumyakanti3578 requested a review from zabetak April 24, 2025 16:21
@soumyakanti3578 soumyakanti3578 marked this pull request as ready for review April 24, 2025 16:21
zabetak
zabetak reviewed May 5, 2025
View reviewed changes
Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with this part of the code but given that the test pass and there are no new failures I am leaning towards accepting the PR. Left some small comments/questions but we should be close to merge this unless someone else has thoughts on the proposal.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@soumyakanti3578
Copy link
Contributor Author

@zabetak @kasakrisz
Please review again as I have updated the tests. Thank you.

@kasakrisz kasakrisz merged commit 0806772 into apache:master May 15, 2025
4 checks passed
@abstractdog
Copy link
Contributor

@soumyakanti3578, @kasakrisz , @zabetak : seems like the precommit of this patch was green, but when the commit was merged, something else was already committed that altered the expected q.out, hence this failure now:
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/master/2519/tests/

can someone revert or update the q.out as soon as possible? thanks in advance

@soumyakanti3578 soumyakanti3578 mentioned this pull request May 15, 2025
Merged
@soumyakanti3578
Copy link
Contributor Author

I have raised an ADDENDUM PR to fix the failing test: #5815

This was most probably caused by #5798, which removes native table virtual columns from non native tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zabetak zabetak zabetak approved these changes

@kasakrisz kasakrisz kasakrisz approved these changes

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soumyakanti3578 @abstractdog @zabetak @kasakrisz @asf-ci-hive