HIVE-28280: SemanticException when querying VIEW with DISTINCT clause #6103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
soumyakanti3578
force-pushed
the
HIVE-28280
branch
from
51b5bc8 to
d399943
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
thomasrebele
reviewed
Oct 9, 2025
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests passed
tests pending
tests unstable
labels
zabetak
reviewed
Oct 10, 2025
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
thomasrebele
approved these changes
Oct 29, 2025
Contributor
thomasrebele
left a comment
thomasrebele
left a comment
There was a problem hiding this comment.
Minor suggestion to make the code more efficient. Otherwise LGTM.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
zabetak
approved these changes
Nov 6, 2025
Member
zabetak
left a comment
zabetak
left a comment
There was a problem hiding this comment.
The changes LGTM! I left some minor questions & some nits. I wouldn't insist much on addressing the nits but it would be nice to have a new CI run since the last one was sometime ago and results may be obsolete by now so leaving those at your judgement.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/RelFieldTrimmer.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
ql/src/test/queries/clientpositive/view_top_relnode_not_project_authorization.q
Outdated
Show resolved
Hide resolved
ql/src/test/queries/clientpositive/view_top_relnode_not_project_authorization.q
Show resolved
Hide resolved
Comment on lines
+69
to
+90
| CBO PLAN: | ||
| HiveFilter(condition=[>($0, _UTF-16LE'a')]) | ||
| HiveProject(username=[$0]) | ||
| HiveSortLimit(fetch=[1]) | ||
| HiveProject(username=[$0]) | ||
| HiveFilter(condition=[>($1, 10)]) | ||
| HiveTableScan(table=[[default, t1]], table:alias=[t1]) |
Member
There was a problem hiding this comment.
I don't see the order by id reflected in the plan. Is this normal? Does it really matter that is present in the view definition?
Contributor
Author
There was a problem hiding this comment.
This seems to be by design, and can be controlled by:
HIVE_REMOVE_ORDERBY_IN_SUBQUERY("hive.remove.orderby.in.subquery", true,
"If set to true, order/sort by without limit in sub queries will be removed.")
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
Outdated
Show resolved
Hide resolved
soumyakanti3578
force-pushed
the
HIVE-28280
branch
from
623cc6d to
ff6e6bd
Compare
|
Member
|
Thanks for the PR @soumyakanti3578 and @thomasrebele for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Earlier we expected a view's logical plan to always have a
HiveProjectas its top node. But we can haveHiveSortLimittoo if the original view definition has a limit.We should support all
RelNodes and not justHiveProject.Why are the changes needed?
We get an error as described in https://issues.apache.org/jira/browse/HIVE-28280, https://issues.apache.org/jira/browse/HIVE-21163
Does this PR introduce any user-facing change?
No
How was this patch tested?