Revert "HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs #6139
+59
−2,578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kasakrisz, i've removed the thrift change, however, now i think if we should revert the whole thing as it's not used. |
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
|
@dengzhhu653, WDYT, should we just revert HIVE-23931 ? |
I think it's ok to revert it if we confirm those fields are useless. The old client can still take to the new HMS |
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
deniskuzZ
changed the title
…aints HMS APIs (Ashish Sharma, reviewed by Kishan Das, Zoltan Haindrich)" This reverts commit 8af656c.
|
The optional string validWriteIdList and optional i64 tableId = -1 fields are not used; Thrift will automatically skip them if older clients include them in their requests. |
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
tests unstable
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed redundant calls
Why are the changes needed?
TechDebt
Does this PR introduce any user-facing change?
No
How was this patch tested?
jenkins