HIVE-29274: Flaky TestMetastoreLeaseLeader#testHouseKeepingThreads #6142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
reviewed
Oct 20, 2025
...unit/src/test/java/org/apache/hadoop/hive/metastore/MetastoreHousekeepingLeaderTestBase.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 20, 2025
...unit/src/test/java/org/apache/hadoop/hive/metastore/MetastoreHousekeepingLeaderTestBase.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 20, 2025
...unit/src/test/java/org/apache/hadoop/hive/metastore/MetastoreHousekeepingLeaderTestBase.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 20, 2025
...ive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetastoreHousekeepingLeader.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 20, 2025
...tore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/LeaderElectionContext.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 20, 2025
...astore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/LeaseLeaderElection.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 20, 2025
...astore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/LeaseLeaderElection.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 20, 2025
...astore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/LeaseLeaderElection.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 20, 2025
...astore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 20, 2025
...astore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests passed
tests failed
and removed
tests passed
tests pending
tests failed
labels
dengzhhu653
force-pushed
the
HIVE-29274
branch
from
4f6e514 to
9f03d15
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
deniskuzZ
reviewed
Oct 25, 2025
...tore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/LeaderElectionContext.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 25, 2025
...tore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/LeaderElectionContext.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 25, 2025
...unit/src/test/java/org/apache/hadoop/hive/metastore/MetastoreHousekeepingLeaderTestBase.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 25, 2025
...tastore-server/src/test/java/org/apache/hadoop/hive/metastore/leader/TestLeaderElection.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 25, 2025
| private static final Logger LOG = LoggerFactory.getLogger(LeaseLeaderElection.class); | ||
|
|
||
| private static final AtomicLong ID = new AtomicLong(); | ||
| protected static final AtomicLong ID = new AtomicLong(); |
There was a problem hiding this comment.
won't it be better if we expose protected fields via getters?
deniskuzZ
approved these changes
Oct 25, 2025
dengzhhu653
force-pushed
the
HIVE-29274
branch
from
5d5ab4a to
c71ee31
Compare
dengzhhu653
force-pushed
the
HIVE-29274
branch
from
c71ee31 to
5a4b97b
Compare
dengzhhu653
force-pushed
the
HIVE-29274
branch
from
5a4b97b to
df3ba12
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
https://ci.hive.apache.org/job/hive-flaky-check/927