Skip to content

HIVE-29280: Drop deprecated methods from Metastore server side #6148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

HIVE-29280: Drop deprecated methods from Metastore server side #6148

wants to merge 3 commits into from

Conversation

@dengzhhu653
Copy link
Member

@dengzhhu653 dengzhhu653 commented Oct 22, 2025 •
edited
Loading

What changes were proposed in this pull request?

In RawStore, AlterHandler and IHMSHandler, we have many methods marked as deprecated even since 2.2.0. It's good to drop them off in the next major release to keep the code clean and maintainable.
This will only remove those the Metastore server uses, it shouldn't affect the client side

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@Aggarwal-Raghav
Copy link
Contributor

Can you please address the basic checkstyle sonarqube checks like:

  1. Double semicolon at end
  2. Unused imports
  3. Line is longer than 120 characters (found 131).

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@deniskuzZ deniskuzZ mentioned this pull request Oct 27, 2025
Open
deniskuzZ
deniskuzZ reviewed Oct 27, 2025
View reviewed changes
.../server-extensions/src/main/java/org/apache/hive/hcatalog/listener/NotificationListener.java
try {
newTbl = handler.get_table_core(tbl.getCatName(), tbl.getDbName(), tbl.getTableName())
.deepCopy();
GetTableRequest getTableRequest = new GetTableRequest(tbl.getDbName(), tbl.getTableName());
Copy link
Member

@deniskuzZ deniskuzZ Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: could we rename var to tableRequest as it looks like method name

deniskuzZ
deniskuzZ reviewed Oct 27, 2025
View reviewed changes
...unit/src/test/java/org/apache/hadoop/hive/metastore/TestDisallowColChangesExceptionList.java
stmt.execute("alter table testText change column c2 c2 smallint");
fail("Exception not thrown");
} catch (Exception e1) {
LOG.error("message: {}", e1.getMessage(), e1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that useful in a test?

deniskuzZ
deniskuzZ reviewed Oct 27, 2025
View reviewed changes
...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
try {
String[] parsedDbName = parseDbName(dbName, conf);
Table tbl = get_table_core(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName);
GetTableRequest getTableRequest = new GetTableRequest(parsedDbName[DB_NAME], tableName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it more convenient to keep this method and use new API, maybe just change to private

@deniskuzZ
Copy link
Member

Could we please make the PR title and description a bit more specific?
What criteria were used for deciding which methods to deprecate? For instance, @deprecated drop_partition_by_name hasn’t been removed.

@dengzhhu653
Copy link
Member Author

Could we please make the PR title and description a bit more specific? What criteria were used for deciding which methods to deprecate? For instance, @deprecated drop_partition_by_name hasn’t been removed.

Sure, these are the methods that the Metastore server uses, it shouldn't affect the Hive Metastore client

@dengzhhu653 dengzhhu653 changed the title HIVE-29280: Drop deprecated methods from Metastore HIVE-29280: Drop deprecated methods from Metastore server side Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deniskuzZ deniskuzZ deniskuzZ left review comments

+1 more reviewer

@Aggarwal-Raghav Aggarwal-Raghav Aggarwal-Raghav left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dengzhhu653 @Aggarwal-Raghav @deniskuzZ @asf-ci-hive